-
Notifications
You must be signed in to change notification settings - Fork 353
Add optional feature texture-formats-tier2
#5226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Previews, as seen when this build job started (784d5b4): |
kainino0x
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! (Still needs reviews from mozilla+apple)
teoxoy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! 🎉
These were added in the upstream WebGPU API and should be reflected here. - gpuweb/gpuweb#5147 Ordered at the top for consistency even though it changes the numbering of everything else. Also fixed the ordering of TimestampQuery to match since the numbering is changing anyway. (Even though the ordering doesn't really matter because it's nonobservable upstream and there isn't really an ordering.) - gpuweb/gpuweb#5160 - gpuweb/gpuweb#5226 The renumbering is technically a breaking change because it changes the ABI (which shouldn't matter right now) and could affect code that depends on comparing enum values or hard-coded integer versions of them.
Tier 1 PRs for WebGPU spec.: [`gpuweb`gfx-rs#5213](gpuweb/gpuweb#5213) and [`gpuweb`gfx-rs#5160](gpuweb/gpuweb#5160). Tier 2 PR for WebGPU spec.: [`gpuweb`gfx-rs#5226](gpuweb/gpuweb#5226)
Tier 1 PRs for WebGPU spec.: [`gpuweb`gfx-rs#5213](gpuweb/gpuweb#5213) and [`gpuweb`gfx-rs#5160](gpuweb/gpuweb#5160). Tier 2 PR for WebGPU spec.: [`gpuweb`gfx-rs#5226](gpuweb/gpuweb#5226)
Tier 1 PRs for WebGPU spec.: [`gpuweb`gfx-rs#5213](gpuweb/gpuweb#5213) and [`gpuweb`gfx-rs#5160](gpuweb/gpuweb#5160). Tier 2 PR for WebGPU spec.: [`gpuweb`gfx-rs#5226](gpuweb/gpuweb#5226)
This patch adds the optional feature
texture-formats-tier2with below new featuresbased on the previous investigation:
read-writestorage texture access on below texture formats:r8unormr8uintr8sintrgba8unormrgba8uintrgba8sintr16uintr16sintr16floatrgba16uintrgba16sintrgba16floatrgba32uintrgba32sintrgba32floattexture-formats-tier2will also enabletexture-formats-tier1.Fixed: #3838