Revert "Expose limits on the adapter" #494
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 53bf767.
Contributor
Author
|
Apple needs one more week to discuss this change. Sorry for the noise! |
Contributor
|
This is just hiding the extensions? Was the idea that we'd expose it as a struct instead of an object, instead? (cc @zakorgy) |
ben-clayton
pushed a commit
to ben-clayton/gpuweb
that referenced
this pull request
Sep 6, 2022
* Clean code for createTexture validation tests It includes: - move destroy related tests in createTexture.spec.ts to texture/destroy.spec.ts - remove duplicated tests in texture/destroy.spec.ts - remove unneeded comments in createTexture.spec.ts - add a few more tests about texture size in createTexture.spec.ts - add 'undefined' as a dimension type in tests - move kTexFmtInfoHeader to the top in capability_info.js - set and use default values in TextureFormatInfo if we can in capability_info.js * Finally we can remove getDescriptor as Kai suggested in previous PR * Address feedback from Kai * Update src/webgpu/api/validation/texture/destroy.spec.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #489
Corentin says this is okay: https://lists.w3.org/Archives/Member/internal-gpu/2019Nov/0008.html
Preview | Diff