Adjusts subgroup built-in name verbs to match atomics operations#4627
Merged
kdashg merged 1 commit intogpuweb:mainfrom Jun 4, 2024
Merged
Adjusts subgroup built-in name verbs to match atomics operations#4627kdashg merged 1 commit intogpuweb:mainfrom
kdashg merged 1 commit intogpuweb:mainfrom
Conversation
This PR is part of gpuweb#4528 which only changes two operations ``` subgroupSum -> subgroupAdd subgroupProduct -> subgroupMul ``` And making builtin's consistent with GLSL, WGSL atomics and wgpu.
|
munrocket marked as non substantive for IPR from ash-nazg. |
Contributor
|
Previews, as seen when this build job started (3bad199): |
kdashg
changed the title
mwyrzykowski
approved these changes
Jun 4, 2024
Contributor
WGSL 2024-06-04 Minutes
|
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part of #4528 which only changes two operations
And making builtin's consistent with GLSL, WGSL atomics and wgpu.