Fix the computation of inter-stage shader components #4503
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the validation of inter-stage interfaces, each user-defined inter-stage shader variable should always consume 4 inter-stage shader components because in latest Vulkan SPEC the Location value specifies an interface slot comprised of a 32-bit four-component vector conveyed between stages. Fixes: gpuweb#1962
Contributor
|
Previews, as seen when this build job started (60a1d91): |
Kangz
approved these changes
Feb 28, 2024
Contributor
Kangz
left a comment
Kangz
left a comment
There was a problem hiding this comment.
LGTM but I'd like editors to review and other browser engines to agree to this bugfix.
kainino0x
reviewed
Feb 28, 2024
Contributor
kainino0x
left a comment
kainino0x
left a comment
There was a problem hiding this comment.
Pretty sure this will work, left my concerns in the issue.
kainino0x
approved these changes
Feb 28, 2024
mwyrzykowski
approved these changes
Feb 28, 2024
kdashg
approved these changes
Mar 7, 2024
kainino0x
added
the
needs-cts-issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the validation of inter-stage interfaces, each user-defined inter-stage shader variable should always consume 4 inter-stage shader components because in latest Vulkan SPEC the Location value specifies an interface slot comprised of a 32-bit four-component vector conveyed between stages.
Fixes: #1962