Skip to content

Add rgb10a2uint texture format #4245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kainino0x merged 1 commit into from
Jul 26, 2023
Merged

Add rgb10a2uint texture format #4245

kainino0x merged 1 commit into from
Jul 26, 2023

Conversation

@teoxoy
Copy link
Member

@teoxoy teoxoy commented Jul 25, 2023

resolves #3841

@github-actions
Copy link
Contributor

github-actions bot commented Jul 25, 2023

Previews, as seen when this build job started (acb6f46):
WebGPU webgpu.idl | Explainer | Correspondence Reference
WGSL grammar.js | wgsl.lalr.txt

kainino0x
kainino0x reviewed Jul 25, 2023
View reviewed changes
spec/index.bs
<td>
<td>
<td>4
<td>8
Copy link
Contributor

@kainino0x kainino0x Jul 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have a reference for this 8? It seems likely but I don't actually know. I don't think we have a way to look this up except to test the Metal validation layers and see what they do (or have @litherum figure it out)

Copy link
Member Author

@teoxoy teoxoy Jul 26, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was assuming it would be the same as rgb10a2unorm.

I looked through the repo and found the comment below which I think confirms this.

Packed formats cost as-if each channel was 16-bits wide

from #2965 (comment)

Alignment is also 4 according to #2965 (comment).

@kainino0x kainino0x added the needs-cts-issue This change requires tests (or would need tests if accepted), but may not have a CTS issue filed yet label Jul 26, 2023
@kainino0x
Copy link
Contributor

kainino0x commented Jul 26, 2023

meeting: we're OK with feature detection by catching the exception. Ship it!

@kainino0x kainino0x added this to the Polish post-V1 milestone Jul 26, 2023
@kainino0x kainino0x merged commit d05b2d8 into gpuweb:main Jul 26, 2023
@teoxoy teoxoy deleted the patch-3 branch July 27, 2023 08:25
juj added a commit to juj/wasm_webgpu that referenced this pull request Aug 4, 2023
@juj
IDL: Add support for rgb10a2uint texture format. gpuweb/gpuweb#4245
c4e8327
@kainino0x kainino0x modified the milestones: Polish post-V1, Milestone 1 Aug 15, 2023
@caugner caugner mentioned this pull request Nov 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kainino0x kainino0x kainino0x approved these changes

Assignees

No one assigned

Labels

needs-cts-issue This change requires tests (or would need tests if accepted), but may not have a CTS issue filed yet

Projects

None yet

Milestone

Milestone 1

Development

Successfully merging this pull request may close these issues.

Add rgb10a2uint texture format

2 participants

@teoxoy @kainino0x