Add maxBindGroupsPlusVertexBuffers limit #3788
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes gpuweb#2749 On an implementation on top of Metal that chooses to use argument buffers, bind groups and vertex buffers use the same metal resource (vertex buffer slots). This limit allows the site to trade-off bind groups and vertex buffers themselves, as long as the total sum of them don't exceed a limit. This will be a bit tricky to implement on Metal if it's possible to unbind vertex buffers or bind groups (see gpuweb#3787) but I think it's possible and worth the tradeoff to not expose the complexity to the web, but to instead just handle it in the browser.
Contributor
|
Previews, as seen when this build job started (c9901b5): |
Contributor
Author
|
I think this actually has to be more complicated, because the site is allowed to bind more bind groups than the pipeline requires. E.g: |
Contributor
|
FTR: Let's centralize the discussion on the parent issue, #2749 |
Contributor
|
Closing this draft in favor of #3938 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2749
On an implementation on top of Metal that chooses to use argument buffers, bind groups and vertex buffers use the same metal resource (vertex buffer slots). This limit allows the site to trade-off bind groups and vertex buffers themselves, as long as the total sum of them don't exceed a limit.
This will be a bit tricky to implement on Metal if it's possible to unbind vertex buffers or bind groups (see
#3787) but I think it's possible and worth the tradeoff to not expose the complexity to the web, but to instead just handle it in the browser.