Make the spec look more like a spec #365
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This PR doesn't change anything substantive (except for the changes in the first commit, which is #364), so please review the overall structure in the non-diff rendered version. |
Contributor
Author
|
(In particular, the way that prose is inserted between code blocks. No need to review the structure in detail yet - I'm sure it will continue changing once we have a spec editing process.) FYI, I was thinking of opening another PR which splits some of the interfaces into many partial interfaces, so that each function can be defined in a more useful place (e.g. createBuffer in the Buffers section). Haven't settled on that idea yet though. |
kainino0x
force-pushed
the
specify-the-spec
branch
from
0b82f59 to
749bfbe
Compare
kdashg
approved these changes
Jul 12, 2019
Contributor
kdashg
left a comment
kdashg
left a comment
There was a problem hiding this comment.
Cool, thanks for doing this!
Kangz
reviewed
Jul 12, 2019
kainino0x
force-pushed
the
specify-the-spec
branch
from
749bfbe to
79f7cf5
Compare
- Chunk the IDL into small parts - Move prose from comments into the newly created spaces - Re-order some things for consistency and readability Fixes gpuweb#353
kainino0x
force-pushed
the
specify-the-spec
branch
from
79f7cf5 to
58af94d
Compare
Contributor
Author
|
Thanks for the reviews! |
This was referenced Jul 12, 2019
Closed
ben-clayton
pushed a commit
to ben-clayton/gpuweb
that referenced
this pull request
Sep 6, 2022
* Simplify texelData helpers - Removes componentType from capability_info since it can be computed from dataType. - Removes dataType from capability_info since it is only used by texelData. - Removes multiple impl of X -> packed representation. Now just data rep -> packed. Previously: - shader rep -> packed - data rep -> packed - Standardizes helpers for decoding from or encoding into the data representation. - Assorted code cleanup * Address review feedbpack * Address review feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #353
Preview | Diff