Disambiguate precedence of & and * vs. [] and .member in lhs_expression #3582
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make it the same as in the ordinary kind of expression: - unary & and unary * are lower precedence than [] indexing and .member selection. Fixes: gpuweb#3530
Contributor
|
Previews, as seen when this build job started (539e0d7): |
dneto0
added
the
wgsl resolved
mehmetoguzderin
approved these changes
Nov 8, 2022
Contributor
Author
|
I was also tempted to do two cleanups:
That way we get a nice parallel structure between lhs_expression and singular_expression But I avoided that, to keep this PR small. |
Member
|
@dneto0 FTTB it'll also make easier to sync style PR but I think those are good changes to include eventually |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it the same as in the ordinary kind of expression:
Fixes: #3530