-
Notifications
You must be signed in to change notification settings - Fork 353
Reject create*PipelineAsync on failure #3523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Proposal Fixes 3296
|
Previews, as seen when this build job started (d26e47c): |
|
I started updating this to have an exception object that we could extend in the future to provide structured error data if we want to. However, I ended up realizing there are guidelines that prevent us from doing so. WebIDL doesn't allow defining custom exception types:
Meanwhile the Promises guide says:
I believe this doc is more-or-less authoritative. Unfortunately, the somewhat more maintained Design Principles don't say much: Technically, I'm sure it's possible to create a plain I haven't thought of any good alternatives yet. |
99a5f20 to
e2e15aa
Compare
toji
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a couple of nits
Proposed change
Fixes #3296 (note #3297 remains open post-v1)