Skip to content

Make error reporting unordered #3362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kainino0x merged 2 commits into from
Aug 30, 2022
Merged

Make error reporting unordered #3362

kainino0x merged 2 commits into from
Aug 30, 2022

Conversation

@kainino0x
Copy link
Contributor

@kainino0x kainino0x commented Aug 23, 2022 •
edited
Loading

  • No constraint on ordering of parent-child and sibling error scopes.
  • No constraint on which error inside the scope gets reported.
  • (not yet discussed) No constraint on ordering of error scope resolve vs device.lost resolve. left as open issue

Fixes #2119

@kainino0x kainino0x requested a review from toji August 23, 2022 23:25
@kainino0x kainino0x added the tacit resolution queue Editors have agreed and intend to land if no feedback is given label Aug 23, 2022
@kainino0x kainino0x added this to the V1.0 milestone Aug 23, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Aug 23, 2022

Previews, as seen when this build job started (0e0a1a8):
WebGPU webgpu.idl | Explainer | Correspondence Reference
WGSL grammar.js | wgsl.lalr.txt

@kainino0x kainino0x added tacit resolution candidate Editors may be able to resolve and move to tacit resolution queue for webgpu editors meeting and removed tacit resolution queue Editors have agreed and intend to land if no feedback is given tacit resolution candidate Editors may be able to resolve and move to tacit resolution queue labels Aug 24, 2022
toji
toji approved these changes Aug 25, 2022
View reviewed changes
Copy link
Member

@toji toji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kainino0x kainino0x added copyediting Pure editorial stuff (copyediting, *.bs file syntax, etc.) and removed for webgpu editors meeting tacit resolution candidate Editors may be able to resolve and move to tacit resolution queue labels Aug 30, 2022
@kainino0x kainino0x mentioned this pull request Aug 30, 2022
Closed
8 tasks
@kainino0x
Copy link
Contributor Author

kainino0x commented Aug 30, 2022

editors: unblock this on the device.lost issue, that is really #1629

@github-actions
Copy link
Contributor

github-actions bot commented Aug 30, 2022

Previews, as seen when this build job started (a5082c8):
WebGPU webgpu.idl | Explainer | Correspondence Reference
WGSL grammar.js | wgsl.lalr.txt

@kainino0x kainino0x merged commit 8f31717 into gpuweb:main Aug 30, 2022
@kainino0x kainino0x deleted the error-unordered branch August 30, 2022 22:35
@greggman greggman mentioned this pull request Sep 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@toji toji toji approved these changes

Assignees

No one assigned

Labels

copyediting Pure editorial stuff (copyediting, *.bs file syntax, etc.)

Projects

None yet

Milestone

Milestone 0

Development

Successfully merging this pull request may close these issues.

Consider making ShaderModule compilation errors special

2 participants

@kainino0x @toji