Add predeclared short names for vector types #3291
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dneto0
added
wgsl
alan-baker
requested changes
Aug 9, 2022
wgsl/index.bs
Outdated
|
|
||
| <table class='data'> | ||
| <thead> | ||
| <tr><th>Type<th>Predeclared alias<th>Restrictions |
Contributor
There was a problem hiding this comment.
Suggest swapping the first two columns.
I'd also suggest condensing the number of rows by leaving N unspecified. We don't list vec2, vec3, vec4 individually above. Then add an example, which is probably deserved anyways.
Contributor
Author
There was a problem hiding this comment.
I'd also suggest condensing the number of rows by leaving N unspecified.
Both @dj2 and @jimblandy like the explicitness. I like the explicitness because it makes it easier to search and find.
dneto0
removed
the
copyediting
Contributor
|
Previews, as seen when this build job started (ca28d8e): |
Member
|
@dneto0 the PR is great but needs to be updated with upstream I think |
alan-baker
approved these changes
Nov 28, 2022
Contributor
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #736