Skip to content

Add maxColorAttachments missing from GPUSupportedLimits #2985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kainino0x merged 2 commits into from
Jun 7, 2022
Merged

Add maxColorAttachments missing from GPUSupportedLimits #2985

kainino0x merged 2 commits into from
Jun 7, 2022

Conversation

@kainino0x
Copy link
Contributor

@kainino0x kainino0x commented May 31, 2022 •
edited by pr-preview bot
Loading

Fix for #2820
Noted in #2965

Preview | Diff

@kainino0x kainino0x added the copyediting Pure editorial stuff (copyediting, *.bs file syntax, etc.) label May 31, 2022
@kainino0x kainino0x requested a review from greggman May 31, 2022 18:57
@kainino0x kainino0x enabled auto-merge (squash) May 31, 2022 18:57
@github-actions
Copy link
Contributor

github-actions bot commented May 31, 2022

Previews, as seen when this build job started (40e475d):
WebGPU | IDL
WGSL
Explainer

@kainino0x kainino0x requested a review from toji June 7, 2022 21:33
@kainino0x kainino0x merged commit 356791f into gpuweb:main Jun 7, 2022
github-actions bot added a commit that referenced this pull request Jun 7, 2022
@kainino0x @github-actions
Add maxColorAttachments missing from GPUSupportedLimits (#2985)
fe4fd2d 
SHA: 356791f
Reason: push, by @kainino0x

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Jun 7, 2022
@kainino0x @github-actions
Add maxColorAttachments missing from GPUSupportedLimits (#2985)
52e70ef 
SHA: 356791f
Reason: push, by @kainino0x

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@kainino0x kainino0x deleted the maxcolorattachments-fix branch June 7, 2022 21:48
github-actions bot added a commit that referenced this pull request Jun 7, 2022
@kainino0x @github-actions
Add maxColorAttachments missing from GPUSupportedLimits (#2985)
901da2f 
SHA: 356791f
Reason: push, by @kainino0x

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@kainino0x kainino0x added the needs-cts-issue This change requires tests (or would need tests if accepted), but may not have a CTS issue filed yet label Jun 29, 2022
jdarpinian pushed a commit to jdarpinian/gpuweb that referenced this pull request Aug 12, 2022
@kainino0x @jdarpinian
Add maxColorAttachments missing from GPUSupportedLimits (gpuweb#2985)
0b113a6 
Fix for gpuweb#2820
Noted in gpuweb#2965
juj added a commit to juj/wasm_webgpu that referenced this pull request Aug 18, 2022
@juj
IDL: Add maxInterStageShaderVariables and maxColorAttachments limits. g…
0e6ffc7 
…puweb/gpuweb#2857 and gpuweb/gpuweb#2985
@lokokung lokokung removed the needs-cts-issue This change requires tests (or would need tests if accepted), but may not have a CTS issue filed yet label Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@toji toji toji approved these changes

@greggman greggman Awaiting requested review from greggman

Assignees

No one assigned

Labels

copyediting Pure editorial stuff (copyediting, *.bs file syntax, etc.)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kainino0x @toji @lokokung