Skip to content

Add a limit for maxColorAttachments #2820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kdashg merged 1 commit into from
May 5, 2022
Merged

Add a limit for maxColorAttachments #2820

kdashg merged 1 commit into from
May 5, 2022

Conversation

@kainino0x
Copy link
Contributor

@kainino0x kainino0x commented May 4, 2022 •
edited by pr-preview bot
Loading

TBD whether it's configurable - see #1865 - but I'm guessing it will be.

Preview | Diff

@kainino0x kainino0x added the tacit resolution candidate Editors may be able to resolve and move to tacit resolution queue label May 4, 2022
@kainino0x kainino0x requested a review from toji May 4, 2022 00:07
@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2022

Previews, as seen when this build job started (ba5caae):
WebGPU | IDL
WGSL
Explainer

toji
toji approved these changes May 4, 2022
View reviewed changes
Copy link
Member

@toji toji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for adding this.

@kainino0x kainino0x added tacit resolution queue Editors have agreed and intend to land if no feedback is given and removed tacit resolution candidate Editors may be able to resolve and move to tacit resolution queue labels May 4, 2022
@kdashg kdashg merged commit d51e341 into gpuweb:main May 5, 2022
github-actions bot added a commit that referenced this pull request May 5, 2022
@kainino0x @github-actions
Add a limit for maxColorAttachments (#2820)
c0b972b 
SHA: d51e341
Reason: push, by @kdashg

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request May 5, 2022
@kainino0x @github-actions
Add a limit for maxColorAttachments (#2820)
fbec084 
SHA: d51e341
Reason: push, by @kdashg

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request May 5, 2022
@kainino0x @github-actions
Add a limit for maxColorAttachments (#2820)
7bd304d 
SHA: d51e341
Reason: push, by @kdashg

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@kainino0x kainino0x deleted the color-attachments-limit branch May 5, 2022 00:30
@kainino0x
Copy link
Contributor Author

kainino0x commented May 5, 2022

For the record, @kdashg raises the point that this number really is the maximum in practice - a very quick check shows there are no Vulkan or Metal devices that go over 8.

So that makes a strong argument for making it non-configurable in #1865.

@kainino0x kainino0x removed the tacit resolution queue Editors have agreed and intend to land if no feedback is given label May 10, 2022
toji added a commit that referenced this pull request May 12, 2022
@toji
Note that face/cull modes don't affect points, lines
e9ae98c 
Fixes #2863.
Also removes an inline issue that was resolved in #2820
@toji toji mentioned this pull request May 12, 2022
Merged
kainino0x pushed a commit that referenced this pull request May 13, 2022
@toji
Note that face/cull modes don't affect points, lines (#2878)
e02dbb7 
Fixes #2863.
Also removes an inline issue that was resolved in #2820
kainino0x added a commit to kainino0x/gpuweb that referenced this pull request May 31, 2022
@kainino0x
Add maxColorAttachments missing from GPUSupportedLimits
40e475d 
Fix for gpuweb#2820
Noted in gpuweb#2965
@kainino0x kainino0x mentioned this pull request May 31, 2022
Merged
kainino0x added a commit that referenced this pull request Jun 7, 2022
@kainino0x
Add maxColorAttachments missing from GPUSupportedLimits (#2985)
356791f 
Fix for #2820
Noted in #2965
jdarpinian pushed a commit to jdarpinian/gpuweb that referenced this pull request Aug 12, 2022
@kainino0x @jdarpinian
Add a limit for maxColorAttachments (gpuweb#2820)
df323b1
jdarpinian pushed a commit to jdarpinian/gpuweb that referenced this pull request Aug 12, 2022
@toji @jdarpinian
Note that face/cull modes don't affect points, lines (gpuweb#2878)
bacb7c7 
Fixes gpuweb#2863.
Also removes an inline issue that was resolved in gpuweb#2820
jdarpinian pushed a commit to jdarpinian/gpuweb that referenced this pull request Aug 12, 2022
@kainino0x @jdarpinian
Add maxColorAttachments missing from GPUSupportedLimits (gpuweb#2985)
0b113a6 
Fix for gpuweb#2820
Noted in gpuweb#2965
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@toji toji toji approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kainino0x @toji @kdashg