Fully describe validation of render attachments#2458
Merged
kvark merged 3 commits intogpuweb:mainfrom Dec 30, 2021
Merged
Conversation
kainino0x
force-pushed
the
render-target-dimension
branch
from
fb5119c to
8278942
Compare
kvark
requested changes
Dec 24, 2021
Contributor
kvark
requested changes
Dec 29, 2021
Contributor
kvark
approved these changes
Dec 30, 2021
Contributor
kvark
left a comment
kvark
left a comment
There was a problem hiding this comment.
I wish something could tell us about these kinds of issues in an automated way
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2303
Preview | Diff