Decrease the minimum required maxTextureArrayLayers to 256 #2059
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous value of 2048 was preventing WebGPU from being supported on any ARM Android devices.
Contributor
Author
|
See #513 |
Contributor
|
The previous analysis was that the most prominent/recent devices that didn't meet the limit were from 2016-2017. Is that no longer true? |
Contributor
Author
|
The previous analysis must have been wrong since all ARM devices only support 256. There are new ARM devices shipped all the time. |
kvark
approved these changes
Aug 24, 2021
Contributor
kvark
left a comment
kvark
left a comment
There was a problem hiding this comment.
Well, if that's the case... 😢
kainino0x
approved these changes
Aug 25, 2021
Contributor
kainino0x
left a comment
kainino0x
left a comment
There was a problem hiding this comment.
I went back and checked gpuinfo and this checks out - no ARM has 2048. (From inspection it seems Mali-T880 and Mali-G72 are still the most popular, but they are probably also still current designs even though they're a few years old.)
Contributor
|
And very recent ARM devices bump this to only 1024. |
github-actions bot
added a commit
that referenced
this pull request
Aug 25, 2021
SHA: bba3985 Reason: push, by @kainino0x Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
that referenced
this pull request
Aug 25, 2021
SHA: bba3985 Reason: push, by @kainino0x Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
that referenced
this pull request
Aug 25, 2021
SHA: bba3985 Reason: push, by @kainino0x Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous value of 2048 was preventing WebGPU from being supported on
any ARM Android devices.
💥 Error: 500 Internal Server Error 💥
PR Preview failed to build. (Last tried on Aug 24, 2021, 11:22 AM UTC).
More
PR Preview relies on a number of web services to run. There seems to be an issue with the following one:
🚨 CSS Spec Preprocessor - CSS Spec Preprocessor is the web service used to build Bikeshed specs.
🔗 Related URL
If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.