setBindGroup: make start+length check synchronous #1811
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Contributor
Kangz
approved these changes
Jun 7, 2021
kvark
approved these changes
Jun 7, 2021
austinEng
added a commit
to austinEng/webgpu-cts
that referenced
this pull request
Jul 16, 2021
…h check Related spec pr: gpuweb/gpuweb#1811 Dawn issue: crbug.com/dawn/984
7 tasks
austinEng
added a commit
to gpuweb/cts
that referenced
this pull request
Jul 16, 2021
…h check (#640) Related spec pr: gpuweb/gpuweb#1811 Dawn issue: crbug.com/dawn/984
jiangzhaoming
pushed a commit
to jiangzhaoming/cts
that referenced
this pull request
Jul 21, 2021
…h check (gpuweb#640) Related spec pr: gpuweb/gpuweb#1811 Dawn issue: crbug.com/dawn/984
ben-clayton
pushed a commit
to ben-clayton/gpuweb
that referenced
this pull request
Sep 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
dynamicOffsetsDataStartanddynamicOffsetsDataLengthare used to select a range of thedynamicOffsetsData. If they are out of bounds, this should be an exception, because it's analogous to constructing anew Uint32Arraypointing at a subrange ofdynamicOffsetsData.Also deduplicates the rest of the implementation by calling into the other overload.
Preview | Diff