Add forceSoftware adapter option and isSoftware adapter attribute #1734
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Contributor
|
I guess I should hold my "editor" approval until there's agreement. |
kvark
approved these changes
Jun 1, 2021
kdashg
approved these changes
Jun 7, 2021
Member
Author
|
Rebased, should pass the checks cleanly now. |
Contributor
blueboxd
pushed a commit
to blueboxd/chromium-legacy
that referenced
this pull request
Jun 8, 2021
Matches spec changes in gpuweb/gpuweb#1734. Currently hard-coded to return false for isSoftware and resolve to null is forceSoftware is specified, since we don't currently support software adapters. Bug: 1069302 Change-Id: Ifb30b31dd642127a64855e22af12ebefdd313fa7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2946050 Commit-Queue: Brandon Jones <[email protected]> Reviewed-by: Kai Ninomiya <[email protected]> Cr-Commit-Position: refs/heads/master@{#890065}
ben-clayton
pushed a commit
to ben-clayton/gpuweb
that referenced
this pull request
Sep 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An alternative to #1660 and #1314, suggested here.
Adds a 'forceSoftware' option to
GPURequestAdapterOptionsand anisSoftwareboolean attribute toGPUAdapter.Preview | Diff