-
Notifications
You must be signed in to change notification settings - Fork 353
Add external_texture luminance functions #1681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Feedback from a video expert:
|
db7e58e to
ccd3d69
Compare
|
If we accepted this pull request, and we realized in the future we wanted a more rigorous notion of luminance, how would we accomplish this in the future? |
|
Resolution:
IMO: Likely luma (nonlinear) rather than luminance (linear), to avoid gamma conversion. TBD |
A new function like |
|
A An alternative would be to provide a luminance value and metadata telling them what it means. (Could be either provided at the API level, or returned by the WGSL function.) IMO this seems better suited for a WebCodecs path. |
|
Discussed again. Conclusion this time was we think this can be punted to post-MVP. In the meantime we can experiment to determine how much performance can actually be gained. |
Draft, dependent on #1666
There are some big open questions with this proposal, as discovered when I was trying to write spec for it. It's very possible that speccing a portable behavior for this isn't going to be tractable. We could do a non-portable behavior (where the definition of luminance isn't 100% consistent but is as close as we can get). However the value of this addition may not be worth the spec effort right now, at least until we have some concrete experiments showing performance benefits.
Preview | Diff