Skip to content

Conversation

@toji
Copy link
Member

@toji toji commented Apr 19, 2021

Also added some definitions for the fields that were previously missing.


Preview | Diff

@toji toji force-pushed the compilation-message-span branch from 55b5fce to fe34a12 Compare April 23, 2021 17:23
@toji toji changed the title Added spanStart, spanEnd to GPUCompilationMessage Added offset, length to GPUCompilationMessage Apr 23, 2021
@kainino0x kainino0x merged commit 7a64fc2 into main Apr 26, 2021
@kainino0x kainino0x deleted the compilation-message-span branch April 26, 2021 21:23
@kainino0x kainino0x linked an issue Apr 27, 2021 that may be closed by this pull request
ben-clayton pushed a commit to ben-clayton/gpuweb that referenced this pull request Sep 6, 2022
This change handles situations that require multiple discrete
intervals by having the test specify multiple interval generators when
invoking make*Case. This means that for cases like clamp, there will
need to be two generators, clampMedianInterval and clampMinMaxInterval
that will be passed in.

The upshot is that the code and interfaces in f32_interval.ts do not
need to handle multiple interval returns, so the complexity is
isolated to expression.ts, which should be simplified once the old
framework code can be removed.

Fixes gpuweb#1641
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GPUCompilationMessage: Specify linePos units, consider span

4 participants