arrayLength acts on poitner-to-runtime-array #1619
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Additionally, runtime-sized arrays can only appear in "storage" storage class. |
Contributor
Author
|
Note: Now that we have #1569, this is a breaking change because now you have to supply the & when calling the builtin. (Unless you want to allow |
We already have the rule that no expression has static type that is a runtime-size array. The previous definition of arrayLength violated that rule.
alan-baker
approved these changes
Apr 9, 2021
Contributor
alan-baker
left a comment
alan-baker
left a comment
There was a problem hiding this comment.
This should close #1490 too
ben-clayton
added a commit
to ben-clayton/webgpu-samples
that referenced
this pull request
Jun 11, 2021
Remove access control decorations. See gpuweb/gpuweb#1735 arrayLength() now takes a pointer to the array. See gpuweb/gpuweb#1619
austinEng
pushed a commit
to webgpu/webgpu-samples
that referenced
this pull request
Jun 11, 2021
Remove access control decorations. See gpuweb/gpuweb#1735 arrayLength() now takes a pointer to the array. See gpuweb/gpuweb#1619
ben-clayton
pushed a commit
to ben-clayton/gpuweb
that referenced
this pull request
Sep 6, 2022
…eb#1619) This PR simplifies the names of the existing tests with descriptions. Issue: gpuweb#1618
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already have the rule that no expression has static
type that is a runtime-size array.
The previous definition of arrayLength violated that rule.