Skip to content

Conversation

@autokagami
Copy link
Contributor

@autokagami autokagami commented Apr 1, 2021

🤖 This is an automated pull request to align the spec with the latest Web IDL specification. 🤖

The followings are the Web IDL validation messages, which may help understanding this PR:

  • Validation error at line 2 in gpuweb,2, inside `interface GPUAdapterLimits`:
    interface GPUAdapterLimits {
              ^
    

    Error: Interfaces must have [Exposed] extended attribute. To fix, add, for example, [Exposed=Window]. Please also consider carefully if your interface should also be exposed in a Worker scope. Refer to the WebIDL spec section on Exposed for more information.

  • Validation error at line 2 in gpuweb,3, inside `interface GPUAdapterFeatures`:
    interface GPUAdapterFeatures {
              ^
    

    Error: Interfaces must have [Exposed] extended attribute. To fix, add, for example, [Exposed=Window]. Please also consider carefully if your interface should also be exposed in a Worker scope. Refer to the WebIDL spec section on Exposed for more information.

  • Validation error at line 2 in gpuweb,8, inside `interface GPUAdapter`:
    interface GPUAdapter {
              ^
    

    Error: Interfaces must have [Exposed] extended attribute. To fix, add, for example, [Exposed=Window]. Please also consider carefully if your interface should also be exposed in a Worker scope. Refer to the WebIDL spec section on Exposed for more information.

  • Validation error at line 3 in gpuweb,12, inside `interface GPUBuffer`:
    interface GPUBuffer {
              ^
    

    Error: Interfaces must have [Exposed] extended attribute. To fix, add, for example, [Exposed=Window]. Please also consider carefully if your interface should also be exposed in a Worker scope. Refer to the WebIDL spec section on Exposed for more information.

  • Validation error at line 3 in gpuweb,14, inside `interface GPUBufferUsage`:
    interface GPUBufferUsage {
              ^
    

    Error: Interfaces must have [Exposed] extended attribute. To fix, add, for example, [Exposed=Window]. Please also consider carefully if your interface should also be exposed in a Worker scope. Refer to the WebIDL spec section on Exposed for more information.

  • Validation error at line 3 in gpuweb,15, inside `interface GPUMapMode`:
    interface GPUMapMode {
              ^
    

    Error: Interfaces must have [Exposed] extended attribute. To fix, add, for example, [Exposed=Window]. Please also consider carefully if your interface should also be exposed in a Worker scope. Refer to the WebIDL spec section on Exposed for more information.

  • Validation error at line 3 in gpuweb,16, inside `interface GPUTexture`:
    interface GPUTexture {
              ^
    

    Error: Interfaces must have [Exposed] extended attribute. To fix, add, for example, [Exposed=Window]. Please also consider carefully if your interface should also be exposed in a Worker scope. Refer to the WebIDL spec section on Exposed for more information.

  • Validation error at line 3 in gpuweb,19, inside `interface GPUTextureUsage`:
    interface GPUTextureUsage {
              ^
    

    Error: Interfaces must have [Exposed] extended attribute. To fix, add, for example, [Exposed=Window]. Please also consider carefully if your interface should also be exposed in a Worker scope. Refer to the WebIDL spec section on Exposed for more information.

  • Validation error at line 2 in gpuweb,20, inside `interface GPUTextureView`:
    interface GPUTextureView {
              ^
    

    Error: Interfaces must have [Exposed] extended attribute. To fix, add, for example, [Exposed=Window]. Please also consider carefully if your interface should also be exposed in a Worker scope. Refer to the WebIDL spec section on Exposed for more information.

  • Validation error at line 2 in gpuweb,25, inside `interface GPUSampler`:
    interface GPUSampler {
              ^
    

    Error: Interfaces must have [Exposed] extended attribute. To fix, add, for example, [Exposed=Window]. Please also consider carefully if your interface should also be exposed in a Worker scope. Refer to the WebIDL spec section on Exposed for more information.

  • Validation error at line 3 in gpuweb,30, inside `interface GPUBindGroupLayout`:
    interface GPUBindGroupLayout {
              ^
    

    Error: Interfaces must have [Exposed] extended attribute. To fix, add, for example, [Exposed=Window]. Please also consider carefully if your interface should also be exposed in a Worker scope. Refer to the WebIDL spec section on Exposed for more information.

  • Validation error at line 3 in gpuweb,32, inside `interface GPUShaderStage`:
    interface GPUShaderStage {
              ^
    

    Error: Interfaces must have [Exposed] extended attribute. To fix, add, for example, [Exposed=Window]. Please also consider carefully if your interface should also be exposed in a Worker scope. Refer to the WebIDL spec section on Exposed for more information.

  • Validation error at line 2 in gpuweb,37, inside `interface GPUBindGroup`:
    interface GPUBindGroup {
              ^
    

    Error: Interfaces must have [Exposed] extended attribute. To fix, add, for example, [Exposed=Window]. Please also consider carefully if your interface should also be exposed in a Worker scope. Refer to the WebIDL spec section on Exposed for more information.

  • Validation error at line 3 in gpuweb,41, inside `interface GPUPipelineLayout`:
    interface GPUPipelineLayout {
              ^
    

    Error: Interfaces must have [Exposed] extended attribute. To fix, add, for example, [Exposed=Window]. Please also consider carefully if your interface should also be exposed in a Worker scope. Refer to the WebIDL spec section on Exposed for more information.

  • Validation error at line 9 in gpuweb,43, inside `interface GPUCompilationMessage`:
    interface GPUCompilationMessage {
              ^
    

    Error: Interfaces must have [Exposed] extended attribute. To fix, add, for example, [Exposed=Window]. Please also consider carefully if your interface should also be exposed in a Worker scope. Refer to the WebIDL spec section on Exposed for more information.

  • Validation error at line 17 in gpuweb,43, inside `interface GPUCompilationInfo`:
    interface GPUCompilationInfo {
              ^
    

    Error: Interfaces must have [Exposed] extended attribute. To fix, add, for example, [Exposed=Window]. Please also consider carefully if your interface should also be exposed in a Worker scope. Refer to the WebIDL spec section on Exposed for more information.

  • Validation error at line 22 in gpuweb,43, inside `interface GPUShaderModule`:
    interface GPUShaderModule {
              ^
    

    Error: Interfaces must have [Exposed] extended attribute. To fix, add, for example, [Exposed=Window]. Please also consider carefully if your interface should also be exposed in a Worker scope. Refer to the WebIDL spec section on Exposed for more information.

  • Validation error at line 3 in gpuweb,47, inside `interface GPUComputePipeline`:
    interface GPUComputePipeline {
              ^
    

    Error: Interfaces must have [Exposed] extended attribute. To fix, add, for example, [Exposed=Window]. Please also consider carefully if your interface should also be exposed in a Worker scope. Refer to the WebIDL spec section on Exposed for more information.

  • Validation error at line 3 in gpuweb,49, inside `interface GPURenderPipeline`:
    interface GPURenderPipeline {
              ^
    

    Error: Interfaces must have [Exposed] extended attribute. To fix, add, for example, [Exposed=Window]. Please also consider carefully if your interface should also be exposed in a Worker scope. Refer to the WebIDL spec section on Exposed for more information.

  • Validation error at line 3 in gpuweb,59, inside `interface GPUColorWrite`:
    interface GPUColorWrite {
              ^
    

    Error: Interfaces must have [Exposed] extended attribute. To fix, add, for example, [Exposed=Window]. Please also consider carefully if your interface should also be exposed in a Worker scope. Refer to the WebIDL spec section on Exposed for more information.

  • Validation error at line 2 in gpuweb,72, inside `interface GPUCommandBuffer`:
    interface GPUCommandBuffer {
              ^
    

    Error: Interfaces must have [Exposed] extended attribute. To fix, add, for example, [Exposed=Window]. Please also consider carefully if your interface should also be exposed in a Worker scope. Refer to the WebIDL spec section on Exposed for more information.

  • Validation error at line 2 in gpuweb,74, inside `interface GPUCommandEncoder`:
    interface GPUCommandEncoder {
              ^
    

    Error: Interfaces must have [Exposed] extended attribute. To fix, add, for example, [Exposed=Window]. Please also consider carefully if your interface should also be exposed in a Worker scope. Refer to the WebIDL spec section on Exposed for more information.

  • Validation error at line 2 in gpuweb,81, inside `interface GPUComputePassEncoder`:
    interface GPUComputePassEncoder {
              ^
    

    Error: Interfaces must have [Exposed] extended attribute. To fix, add, for example, [Exposed=Window]. Please also consider carefully if your interface should also be exposed in a Worker scope. Refer to the WebIDL spec section on Exposed for more information.

  • Validation error at line 19 in gpuweb,83, inside `interface GPURenderPassEncoder`:
    interface GPURenderPassEncoder {
              ^
    

    Error: Interfaces must have [Exposed] extended attribute. To fix, add, for example, [Exposed=Window]. Please also consider carefully if your interface should also be exposed in a Worker scope. Refer to the WebIDL spec section on Exposed for more information.

  • Validation error at line 2 in gpuweb,89, inside `interface GPURenderBundle`:
    interface GPURenderBundle {
              ^
    

    Error: Interfaces must have [Exposed] extended attribute. To fix, add, for example, [Exposed=Window]. Please also consider carefully if your interface should also be exposed in a Worker scope. Refer to the WebIDL spec section on Exposed for more information.

  • Validation error at line 2 in gpuweb,91, inside `interface GPURenderBundleEncoder`:
    interface GPURenderBundleEncoder {
              ^
    

    Error: Interfaces must have [Exposed] extended attribute. To fix, add, for example, [Exposed=Window]. Please also consider carefully if your interface should also be exposed in a Worker scope. Refer to the WebIDL spec section on Exposed for more information.

  • Validation error at line 2 in gpuweb,93, inside `interface GPUQueue`:
    interface GPUQueue {
              ^
    

    Error: Interfaces must have [Exposed] extended attribute. To fix, add, for example, [Exposed=Window]. Please also consider carefully if your interface should also be exposed in a Worker scope. Refer to the WebIDL spec section on Exposed for more information.

  • Validation error at line 2 in gpuweb,94, inside `interface GPUQuerySet`:
    interface GPUQuerySet {
              ^
    

    Error: Interfaces must have [Exposed] extended attribute. To fix, add, for example, [Exposed=Window]. Please also consider carefully if your interface should also be exposed in a Worker scope. Refer to the WebIDL spec section on Exposed for more information.

  • Validation error at line 2 in gpuweb,98, inside `interface GPUCanvasContext`:
    interface GPUCanvasContext {
              ^
    

    Error: Interfaces must have [Exposed] extended attribute. To fix, add, for example, [Exposed=Window]. Please also consider carefully if your interface should also be exposed in a Worker scope. Refer to the WebIDL spec section on Exposed for more information.

  • Validation error at line 2 in gpuweb,100, inside `interface GPUSwapChain`:
    interface GPUSwapChain {
              ^
    

    Error: Interfaces must have [Exposed] extended attribute. To fix, add, for example, [Exposed=Window]. Please also consider carefully if your interface should also be exposed in a Worker scope. Refer to the WebIDL spec section on Exposed for more information.

  • Validation error at line 6 in gpuweb,101, inside `interface GPUDeviceLostInfo`:
    interface GPUDeviceLostInfo {
              ^
    

    Error: Interfaces must have [Exposed] extended attribute. To fix, add, for example, [Exposed=Window]. Please also consider carefully if your interface should also be exposed in a Worker scope. Refer to the WebIDL spec section on Exposed for more information.

  • Validation error at line 2 in gpuweb,103, inside `interface GPUOutOfMemoryError`:
    interface GPUOutOfMemoryError {
              ^
    

    Error: Interfaces must have [Exposed] extended attribute. To fix, add, for example, [Exposed=Window]. Please also consider carefully if your interface should also be exposed in a Worker scope. Refer to the WebIDL spec section on Exposed for more information.

  • Validation error at line 6 in gpuweb,103, inside `interface GPUValidationError`:
    interface GPUValidationError {
              ^
    

    Error: Interfaces must have [Exposed] extended attribute. To fix, add, for example, [Exposed=Window]. Please also consider carefully if your interface should also be exposed in a Worker scope. Refer to the WebIDL spec section on Exposed for more information.

Currently this autofix might introduce awkward code formatting, and feel free to manually fix it whenever it happens.

Please file an issue at https://github.com/saschanaz/webidl-updater/issues/new if you think this is invalid or should be enhanced.


Preview | Diff

Copy link
Contributor

@kvark kvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we actually want Exposed=(Window, DedicatedWorker) on everything

Copy link
Contributor

@kainino0x kainino0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been meaning to do this awhile, handy that it happened automatically [once @saschanaz registered our spec with autokagami; thanks!].

IMO since this PR was automated, we should just land this, there's other stuff missing from the spec for multithreading anyway. We can add DedicatedWorker in a followup.

@kvark
Copy link
Contributor

kvark commented Apr 5, 2021

Ok, sounds reasonable.

@kvark kvark merged commit 1e84e39 into gpuweb:main Apr 5, 2021
ben-clayton pushed a commit to ben-clayton/gpuweb that referenced this pull request Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants