Rename "Value types" to "Plain types" #1568
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Contributor
Plain types are like C++ POD types. It didn't make sense to call something a "value" type (and exclude other types), becuase *every* type is a set of values.
Contributor
alan-baker
approved these changes
Mar 29, 2021
ben-clayton
pushed a commit
to ben-clayton/gpuweb
that referenced
this pull request
Sep 6, 2022
The changes to check for exceptions being thrown in gpuweb#1529 should only apply to cases where we are testing for an required feature being enabled. The updates to createBindGroupLayout.spec.ts were unnecessary and have started causing failures. FYI @Gyuyoung Issue: gpuweb#919
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plain types are like C++ POD types.
It didn't make sense to call something a "value" type (and exclude other
types), becuase every type is a set of values.