Allow sample functions in integer images #1500
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Previously only f32 textures were allowed to be used with sample built-ins * fixed a typo in image mapping
kvark
requested changes
Mar 9, 2021
Contributor
There was a problem hiding this comment.
Not an oversight. HLSL doesn't like this, which is pretty sad.
error: cannot Sample from resource containing uint
Contributor
Author
Ouch ok, I'd almost be in favour only having integer types for storage images then, but I'll close this. |
ben-clayton
pushed a commit
to ben-clayton/gpuweb
that referenced
this pull request
Sep 6, 2022
This implements the F32Interval class and fundamental accuracy functions described in my prototype, gpuweb/cts#1402, for reworking how floating point tests are written. This also adds in testing that did not appear in my prototype. There are a couple of functions that are not currently used that I have included in this patch that have suppressions for unused-vars on them. I included them in this patch since they are logically grouped with this code. These surpressions will be removed in future patches. Review discovered a bug in oneULP's implementation, which is fixed in this PR. Issue gpuweb#792
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
built-ins
I think it was just an oversight that the sampled type was required to be f32.