Entry point arguments and return values #1426
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dj2
reviewed
Feb 10, 2021
wgsl/index.bs
Outdated
| // OpDecorate %gl_SampleMaskIn BuiltIn SampleMask ; an input variable | ||
| // OpDecorate %gl_SampleMaskIn Flat | ||
| [[stage(fragment)]] | ||
| fn main( |
Member
There was a problem hiding this comment.
These functions should all have unique names, so probably vert_main, frag_main and comp_main so that we can compile the example.
Contributor
Author
There was a problem hiding this comment.
would be great to compile it on CI ;)
Member
There was a problem hiding this comment.
@ben-clayton has a script to run them through Tint, but it would be tricky in most cases as the implementation lags the spec, so new spec features would always show up as broken.
Contributor
Author
|
@dj2 your thoughtful review is exactly what this PR needed, thank you! |
Contributor
dj2
reviewed
Feb 10, 2021
kvark
force-pushed
the
entry-point-arguments
branch
from
e695e4b to
6901d13
Compare
2 tasks
dneto0
reviewed
Feb 16, 2021
Contributor
dneto0
left a comment
dneto0
left a comment
There was a problem hiding this comment.
Looks good to me on this reading.
Thanks
|
|
||
| ### Pipeline Input and Output Interface ### {#pipeline-inputs-outputs} | ||
|
|
||
| The <dfn dfn>Entry point IO type</dfn>s include the following: |
Contributor
There was a problem hiding this comment.
I would quibble that these aren't new types but don't want to block on this.
If I think of a better way to say it I can post a followup PR.
Contributor
Author
|
The group has agreed to land this on the today's call. |
dj2
approved these changes
Feb 16, 2021
This was referenced Feb 16, 2021
jrprice
added a commit
to jrprice/gpuweb
that referenced
this pull request
Mar 5, 2021
This is required for the grammar to support the changes made in gpuweb#1426. Also removes two obselete validation rules and replaces them with a new one to state that builtin/location decorations can only appear on entry points.
jrprice
added a commit
to jrprice/gpuweb
that referenced
this pull request
Mar 5, 2021
This is required for the grammar to support the changes made in gpuweb#1426. Also removes two obsolete validation rules and replaces them with a new one to state that builtin/location decorations can only appear on entry points.
jrprice
added a commit
to jrprice/gpuweb
that referenced
this pull request
Mar 5, 2021
This is required for the grammar to support the changes made in gpuweb#1426. Also removes two obsolete validation rules.
This was referenced Mar 7, 2021
dneto0
pushed a commit
that referenced
this pull request
Mar 9, 2021
This is required for the grammar to support the changes made in #1426. Also removes two obsolete validation rules.
ben-clayton
pushed a commit
to ben-clayton/Tint
that referenced
this pull request
Apr 13, 2021
Entry points are now allowed to have parameters and return types as part of the changes made in: gpuweb/gpuweb#1426 Bug: tint:512 Change-Id: I20caa940f6d194f62ce1dfa5d247927c5b5a9628 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/44080 Auto-Submit: James Price <[email protected]> Commit-Queue: Ben Clayton <[email protected]> Reviewed-by: Ben Clayton <[email protected]>
ben-clayton
pushed a commit
to ben-clayton/gpuweb
that referenced
this pull request
Sep 6, 2022
This PR adds unimplemented stubs for the synchronization builtin functions. * `storageBarrier` * `workgroupBarrier` Issue gpuweb#1249, gpuweb#1295
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1315
I'm fairly sure this is incomplete, but it captures the core of the changes.
The example code hasn't been touched since WHSL times :)