Further improvements to createView() #1416
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kainino0x
approved these changes
Feb 5, 2021
Contributor
|
oops accidentally half reviewed |
kainino0x
reviewed
Feb 6, 2021
Contributor
kainino0x
left a comment
kainino0x
left a comment
There was a problem hiding this comment.
This will result in a subtle behavior change around dimension/arrayLayerCount; adding "Needs test plan" (really, "needs test updates")
Member
Author
|
Rebased on the |
Contributor
kainino0x
approved these changes
Feb 9, 2021
ben-clayton
pushed a commit
to ben-clayton/gpuweb
that referenced
this pull request
Sep 6, 2022
This PR adds unimplemented stub tests for the `atomicStore` builtin. Issue gpuweb#1274
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing @kainino0x's post-merge feedback from #1406 (review)
Preview | Diff