Add GPUAdapter.limits #1273
Merged
Add GPUAdapter.limits #1273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kainino0x
requested review from
Kangz,
RafaelCintron,
grorg,
kdashg and
kvark
kvark
reviewed
Dec 3, 2020
Kangz
approved these changes
Dec 7, 2020
Contributor
Kangz
left a comment
Kangz
left a comment
There was a problem hiding this comment.
General approach LGTM, I don't know about the WebIDLisms though.
kdashg
approved these changes
Dec 7, 2020
Contributor
kdashg
left a comment
kdashg
left a comment
There was a problem hiding this comment.
It would be ideal if we didn't need to duplicate the limits struct.
kvark
approved these changes
Dec 7, 2020
Contributor
|
Discussed at the 2020-12-07 meeting. |
Contributor
|
We have conditional consensus to merge this as a way forward, unless we get a negative signal in the next day. |
Contributor
Author
|
@grorg any update? |
kainino0x
commented
Dec 12, 2020
Contributor
Contributor
kainino0x
force-pushed
the
gpuadapterlimits
branch
from
9700b77 to
4410c80
Compare
Contributor
kvark
approved these changes
Dec 15, 2020
kainino0x
changed the title
ben-clayton
pushed a commit
to ben-clayton/gpuweb
that referenced
this pull request
Sep 6, 2022
This PR adds unimplmented stubs for the `atomicLoad` builtin. Issue gpuweb#1273
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it's been determined that this API shouldn't consider privacy budgeting in it's design.
Exact IDL interface is TBD, but editorial.
Needs more text to be filled out later. Also adds some other TODOs.
See also #489, #495; #1098, #1100.
Preview | Diff