Rename binding types #1256
Rename binding types #1256
Conversation
|
I'm not sure about renaming |
|
If we keep the |
|
|
toji
left a comment
toji
left a comment
There was a problem hiding this comment.
I was mildly fond of having a 'type' field across each binding layout variant, but this is fine if you want more descriptive names.
kainino0x
left a comment
kainino0x
left a comment
There was a problem hiding this comment.
lgtm. Only concern is that there's no longer an obvious "primary" field in each of these binding types ('type' -> 'access'|'sampleType'|'type'). But really these fields aren't really any more important than the other fields in the dict, so it should be fine.
|
Ok, I generally agree. We can chat about it more on the editors call. |
|
Fortunately we don't break any users code until we actually implement it, so as long as we get it settled soon it doesn't matter how many times we change it :) |
|
There are users following wgpu-rs master, and I have a PR blocked for landing on this binding type change. I don't want them to port their code on this API, only if we are about to change it right afterwards. |
|
Things we may want to also discuss in the meeting: |
1047: Update bind group layout API to match upstream r=cwfitzgerald a=kvark **Connections** Follows gpuweb/gpuweb#1076, gpuweb/gpuweb#1223 (gpuweb/gpuweb#1164), gpuweb/gpuweb#1255, and gpuweb/gpuweb#1256 **Description** Aligns our API closer to the latest changes in WebGPU upstream. We technically don't have to do this, but I believe in the end it would be best if our API gets close to upstream. Note: this is a sensitive change for the users, everybody will get their code broken. So please take a look at the API and see if something is missing or needs improvement, so that we don't have to go through the changes again afterwards. **Testing** Doesn't really need testing. Partially covered by the existing playtest. Co-authored-by: Dzmitry Malyshau <[email protected]>
This CL adds unimplemented stubs for the `fwidthCoarse` tests. Issue: gpuweb#1256
4 participants
Follow-up to #1223
I think
GPUBufferTypeis confusing since it sounds like something that users would specify at buffer creation, and it doesn't have things like "it's a vertex buffer". This PR renames it toGPUBufferBindingTypeand does the same for samplers and textures for consistency.The storage texture bindings don't really have a type, they have access flags instead. So the field is renamed to
access.Preview | Diff