WGSL: idx -> index #1254
Merged
WGSL: idx -> index #1254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is more consistent with the naming in platform APIs and the saving of 2 characters to type doesn't seem worth the weirdness.
kvark
approved these changes
Nov 24, 2020
Contributor
kvark
left a comment
kvark
left a comment
There was a problem hiding this comment.
That looks good.
I think the distinction between "_id" versus "_index" is most visible in the compute invocation stuff. There is a 3D local ID, then a 3D global ID, then the 1D invocation index. For vertex/index ids, we could go either way, and "_index" seems fine.
dj2
approved these changes
Nov 24, 2020
ben-clayton
pushed a commit
to ben-clayton/gpuweb
that referenced
this pull request
Sep 6, 2022
This CL adds unimplemented tests for the `dpdyFine` builtin. Issue: gpuweb#1254
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1253
This is more consistent with the naming in platform APIs and the saving
of 2 characters to type doesn't seem worth the weirdness.