Add maxStorageBufferBindingSize limit #1163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kangz
reviewed
Oct 21, 2020
Kangz
reviewed
Oct 21, 2020
Contributor
Kangz
left a comment
Kangz
left a comment
There was a problem hiding this comment.
LGTM except that the commit message mentions uniform instead of storage
kvark
changed the title
kainino0x
approved these changes
Oct 22, 2020
Co-authored-by: Kai Ninomiya <[email protected]>
bors bot
added a commit
to gfx-rs/wgpu
that referenced
this pull request
Mar 2, 2021
1241: Update Extent3d::depth and Limits to latest upstream r=grovesNL a=kvark **Connections** - gpuweb/gpuweb#1390 - gpuweb/gpuweb#1328 - gpuweb/gpuweb#1163 - gpuweb/gpuweb#1274 **Description** Just an API update up to spec. **Testing** Tested on wgpu-rs examples Co-authored-by: Dzmitry Malyshau <[email protected]>
ben-clayton
pushed a commit
to ben-clayton/gpuweb
that referenced
this pull request
Sep 6, 2022
…eb#1163) The shader execution zero init tests produce large nested loops on constant indices that are very tempting for drivers to unroll. This commit prevents unrolling by adding zero to the loop bound using a zero coming from a uniform buffer. This is not known to the shader compiler which then can't optimize as much.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Vulkan stats in https://vulkan.gpuinfo.org/displaydevicelimit.php?name=maxStorageBufferRange&platform=windows
Also related to #1135 (comment)
Preview | Diff