Move preferred format queries to the adapter

toji · toji · commit 6f7c215ce767 · 2022-04-18T11:34:23.000-07:00
Fixes #2747 Removes the need to have a canvas context in order to query a preffered format. This should help put developers at ease that they don't need to rebuild all their pipelines when rendering to multiple canvases.
diff --git a/spec/index.bs b/spec/index.bs
@@ -1791,6 +1791,7 @@ interface GPUAdapter {
     readonly attribute boolean isFallbackAdapter;
 
     Promise<GPUDevice> requestDevice(optional GPUDeviceDescriptor descriptor = {});
+    GPUTextureFormat getPreferredContextFormat();
 };
 </script>
 
@@ -1895,6 +1896,23 @@ interface GPUAdapter {
             1. Return |promise|.
 
         </div>
+
+    : <dfn>getPreferredContextFormat()</dfn>
+    ::
+        Returns an optimal {{GPUTextureFormat}} to use for {{GPUCanvasContext}}s with devices
+        created from this adapter.
+
+        <div algorithm="GPUCanvasContext.getPreferredContextFormat">
+            **Called on:** {{GPUAdapter}} |this|.
+
+            **Returns:** {{GPUTextureFormat}}
+
+            <div class=content-timeline>
+                1. Return an optimal {{GPUTextureFormat}} to use when calling
+                    {{GPUCanvasContext/configure()}} on a {{GPUCanvasContext}} with a {{GPUDevice}}
+                    created by |this|. Must be one of the [=supported context formats=].
+            </div>
+        </div>
 </dl>
 
 <div class="example">
@@ -9482,7 +9500,6 @@ interface GPUCanvasContext {
     undefined configure(GPUCanvasConfiguration configuration);
     undefined unconfigure();
 
-    GPUTextureFormat getPreferredFormat(GPUAdapter adapter);
     GPUTexture getCurrentTexture();
 };
 </script>
@@ -9590,27 +9607,6 @@ interface GPUCanvasContext {
             1. Set |this|.{{GPUCanvasContext/[[currentTexture]]}} to `null`.
         </div>
 
-    : <dfn>getPreferredFormat(adapter)</dfn>
-    ::
-        Returns an optimal {{GPUTextureFormat}} to use with this context and devices created from
-        the given adapter.
-
-        <div algorithm="GPUCanvasContext.getPreferredFormat">
-            **Called on:** {{GPUCanvasContext}} this.
-
-            **Arguments:**
-            <pre class=argumentdef for="GPUCanvasContext/getPreferredFormat(adapter)">
-                |adapter|: Adapter the format should be queried for.
-            </pre>
-
-            **Returns:** {{GPUTextureFormat}}
-
-            <div class=content-timeline>
-                1. Return an optimal {{GPUTextureFormat}} to use when calling {{GPUCanvasContext/configure()}}
-                    with the given |adapter|. Must be one of the [=supported context formats=].
-            </div>
-        </div>
-
     : <dfn>getCurrentTexture()</dfn>
     ::
         Get the {{GPUTexture}} that will be composited to the document by the {{GPUCanvasContext}}
@@ -9755,7 +9751,7 @@ dictionary GPUCanvasConfiguration {
 
         context.configure({
             device: gpuDevice,
-            format: context.getPreferredFormat(gpuAdapter),
+            format: gpuAdapter.getPreferredContextFormat(),
         });
     </pre>
 </div>
@@ -9808,7 +9804,7 @@ must be reconfigured by calling {{GPUCanvasContext/configure()}} again with the
                 if (entry.target != canvas) { continue; }
                 context.configure({
                     device: gpuDevice,
-                    format: context.getPreferredFormat(gpuAdapter),
+                    format: gpuAdapter.getPreferredContextFormat(),
                     size: {
                         // This reports the size of the canvas element in pixels
                         width: entry.devicePixelContentBoxSize[0].inlineSize,
