Check GPUAdapterInfo.isFallbackAdapter on explicit fallback request#4483
Merged
kainino0x merged 2 commits intogpuweb:mainfrom Oct 24, 2025
Merged
Conversation
According to specification a fallback adapter may still be returned if forceFallbackAdapter is set to false and either no other appropriate adapter is available or the user agent chooses to return a fallback adapter. https://gpuweb.github.io/gpuweb/#dom-gpurequestadapteroptions-forcefallbackadapter Therefore, checking whether an adapter is a fallback adapter should only be performed if forceFallbackAdapter is true. Issue: gpuweb#4480 Signed-off-by: Andrei Volykhin <[email protected]>
Contributor
Author
|
@kainino0x < Please take a look. |
kainino0x
approved these changes
Oct 24, 2025
Collaborator
kainino0x
left a comment
There was a problem hiding this comment.
Sorry, got behind on reviews for a few days. Thank you for the fix!
5c395ea to
4f74686
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to specification a fallback adapter may still be returned if forceFallbackAdapter is set to false and either no other appropriate adapter is available or the user agent chooses to return a fallback adapter.
https://gpuweb.github.io/gpuweb/#dom-gpurequestadapteroptions-forcefallbackadapter
Therefore, checking whether an adapter is a fallback adapter should only be performed if forceFallbackAdapter is true.
Issue: fixes #4480
Requirements for PR author:
.unimplemented()./** documented */and new helper files are found inhelper_index.txt.Requirements for reviewer sign-off:
When landing this PR, be sure to make any necessary issue status updates.