Add tests for GPUAdapterInfo.isFallbackAdapter#4303
Merged
beaufortfrancois merged 5 commits intomainfrom Mar 26, 2025
Merged
Conversation
beaufortfrancois
force-pushed
the
isFallbackAdapter
branch
from
5310c0e to
75a8683
Compare
Collaborator
Author
|
I think I need to wait for #4302 to land to make CI bots happy and I'll rebase. |
kainino0x
reviewed
Mar 25, 2025
| if (forceFallbackAdapter && !adapter) { | ||
| t.skip('No adapter available'); | ||
| return; | ||
| assert(typeof adapter?.info.isFallbackAdapter === 'boolean'); |
Collaborator
There was a problem hiding this comment.
This assert will fail if adapter is null.
I adjusted the logic a bit and also switched to t.expect. PTAL
Collaborator
Author
There was a problem hiding this comment.
Thanks for catching! LGTM
FWIW, I would have followed the following pattern.
if (!adapter) {
// Failing to create an adapter is only OK when forceFallbackAdapter is true.
t.expect(forceFallbackAdapter === true);
// Mark the test as skipped (as long as nothing else failed before this point).
t.skip('No fallback adapter available');
return;
}
t.expect(adapter.info.isFallbackAdapter === Boolean(forceFallbackAdapter));
await testAdapter(t, adapter);
Collaborator
There was a problem hiding this comment.
That makes sense! Feel free to apply that and land
kainino0x
approved these changes
Mar 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #2356
Requirements for PR author:
.unimplemented()./** documented */and new helper files are found inhelper_index.txt.Requirements for reviewer sign-off:
When landing this PR, be sure to make any necessary issue status updates.