Skip to content

Roll types 0.1.52 -> 0.1.59#4302

Merged
kainino0x merged 2 commits intogpuweb:mainfrom
kainino0x:roll-types
Mar 24, 2025
Merged

Roll types 0.1.52 -> 0.1.59#4302
kainino0x merged 2 commits intogpuweb:mainfrom
kainino0x:roll-types

Conversation

@kainino0x
Copy link
Copy Markdown
Collaborator

This version adds subgroupMinSize/subgroupMaxSize, textureBindingViewDimension, GPUAdapterInfo.isFallbackAdapter, and tweaks some type definitions.

idl_test.ts needed to change because bitmask types changed from object types to interface types, which ran into this subtle difference between the two: microsoft/TypeScript#15300

There shouldn't be any significant test behavior changes but since most of these edits are in common files I wasn't able to verify.

Issue: None


Requirements for PR author:

  • [n/a] All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
  • Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • [n/a] Tests are properly located in the test tree.
  • [n/a] Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • [n/a] Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

@kainino0x kainino0x changed the title Roll types 0.1.52 -> 0.1.58 Roll types 0.1.52 -> 0.1.59 Mar 24, 2025
@kainino0x
Copy link
Copy Markdown
Collaborator Author

Switching to 0.1.59 which has a SharedArrayBuffer fix (that apparently CTS didn't run into).
No CTS code changes though.

@kainino0x kainino0x enabled auto-merge (squash) March 24, 2025 21:59
@kainino0x kainino0x merged commit 54bcb31 into gpuweb:main Mar 24, 2025
1 check passed
@kainino0x kainino0x deleted the roll-types branch March 24, 2025 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants