Repository navigation
Commit 13cb03a
fix(openrouter): profile moonshotai/kimi-k3 with truthful max_tokens and reasoning effort (Zoo-Code-Org#1325)
* fix(openrouter): profile moonshotai/kimi-k3 with truthful max_tokens and reasoning effort
OpenRouter reports max_completion_tokens: null for moonshotai/kimi-k3, so the generic fallback fabricated max_tokens = ceil(context_length * 0.2) (209,716 for a 1M window), and no reasoning effort was ever populated so the reasoning field was dropped from requests. Long turns then burned the upstream 32,768-token output cap on invisible thinking billed as completion tokens.
Add a Moonshot K3 capability profile (maxTokens 32768, supportsReasoningEffort [low, high, max] with model default high, supportsTemperature false) applied in parseOpenRouterModel at fetch time and re-applied in OpenRouterHandler.getModel() at consumption time, so users with stale cached model info are fixed without a re-fetch. The default request body becomes {max_tokens: 32768, reasoning: {effort: high}} with temperature omitted (K3 is fixed at 1.0 server-side).
Adds parse-time, stale-cache, and createMessage wire tests, plus shouldUseReasoningEffort cases for array capability with a model default effort.
* fix(openrouter): address PR 1325 review feedback for Kimi K3
- Send explicit temperature: 1.0 for Moonshot K3 via OpenRouter instead of
omitting it: issue Zoo-Code-Org#1316's expected result requires the request to carry
temperature: 1.0, matching the direct Moonshot provider profile
(defaultTemperature: 1.0, "temperature is fixed at 1.0").
- Add a handler-level regression test for the openRouterSpecificProvider
endpoint branch: a stale endpoint record (fabricated max_tokens, boolean
supportsReasoningEffort) is corrected at consumption time (CodeRabbit
pre-merge check: regression evidence for the endpoint path).
- Restore OpenAI.prototype.chat in the Kimi K3 wire test via try/finally so
the stub cannot leak into later tests; clearAllMocks does not undo
prototype assignment (CodeRabbit actionable comment).
* Keep Moonshot K3 profile literals inside applyOpenRouterMoonshotK3Profile
The mutation-diff gate (Stryker 10 + Vitest 4.1) never activates static
mutants, so module-scope literals report as surviving mutants. Move the
K3 model ids and profile values into the function body where the existing
tests kill every resulting mutant, and drop the OPENROUTER_MOONSHOT_K3_MODELS
export that had no consumers.
* fix(openrouter): match the tilde-prefixed OpenRouter Kimi alias id
The OpenRouter catalogue identifier for the rolling Kimi alias is
~moonshotai/kimi-latest - the ~ prefix is part of the id and is what
reaches applyOpenRouterMoonshotK3Profile as modelId. The previous bare
moonshotai/kimi-latest entry never matched, so the alias case from
issue Zoo-Code-Org#1316 was left unprofiled.
* fix(openrouter): use a direct comparison for the K3 profile guard
Replace the per-call Set allocation in applyOpenRouterMoonshotK3Profile
with the same direct-comparison shape as the gpt-6-astra guard in
parseOpenRouterModel (review feedback: the Set was allocated on every
non-K3 call before the early return).
Add direct unit tests covering both catalogue ids (including the
tilde-prefixed rolling alias ~moonshotai/kimi-latest) and the non-K3
pass-through, so the guard's mutants stay killed at the lowest layer.
* test(shared): cover a user-selected effort outside the K3 ladder
Review feedback: a mutation dropping the .includes() ladder check in
shouldUseReasoningEffort would survive the existing suite (which only
covered the default-effort -> true and enableReasoningEffort: false
-> false directions).
Assert that a user-selected effort ("medium") not present in the K3
capability ladder (["low", "high", "max"]) returns false, both with
and with an explicit enableReasoningEffort: true.
---------
Co-authored-by: Eason Liang <[email protected]>
Co-authored-by: easonLiangWorldedtech <[email protected]>1 parent 169d141 commit 13cb03a
5 files changed
Lines changed: 402 additions & 4 deletions
File tree
- src
- api/providers
- __tests__
- fetchers
- __tests__
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
21 | 24 | | |
22 | 25 | | |
23 | 26 | | |
| |||
43 | 46 | | |
44 | 47 | | |
45 | 48 | | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
46 | 57 | | |
47 | 58 | | |
48 | 59 | | |
| |||
101 | 112 | | |
102 | 113 | | |
103 | 114 | | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
104 | 128 | | |
105 | 129 | | |
106 | 130 | | |
| |||
115 | 139 | | |
116 | 140 | | |
117 | 141 | | |
118 | | - | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
119 | 149 | | |
120 | 150 | | |
121 | 151 | | |
| |||
237 | 267 | | |
238 | 268 | | |
239 | 269 | | |
| 270 | + | |
| 271 | + | |
| 272 | + | |
| 273 | + | |
| 274 | + | |
| 275 | + | |
| 276 | + | |
| 277 | + | |
| 278 | + | |
| 279 | + | |
| 280 | + | |
| 281 | + | |
| 282 | + | |
| 283 | + | |
| 284 | + | |
| 285 | + | |
| 286 | + | |
| 287 | + | |
| 288 | + | |
| 289 | + | |
| 290 | + | |
| 291 | + | |
| 292 | + | |
| 293 | + | |
| 294 | + | |
| 295 | + | |
| 296 | + | |
| 297 | + | |
| 298 | + | |
| 299 | + | |
| 300 | + | |
| 301 | + | |
| 302 | + | |
| 303 | + | |
| 304 | + | |
| 305 | + | |
| 306 | + | |
| 307 | + | |
| 308 | + | |
| 309 | + | |
| 310 | + | |
| 311 | + | |
| 312 | + | |
| 313 | + | |
| 314 | + | |
| 315 | + | |
| 316 | + | |
| 317 | + | |
| 318 | + | |
| 319 | + | |
| 320 | + | |
| 321 | + | |
| 322 | + | |
| 323 | + | |
| 324 | + | |
| 325 | + | |
| 326 | + | |
| 327 | + | |
| 328 | + | |
| 329 | + | |
| 330 | + | |
| 331 | + | |
| 332 | + | |
| 333 | + | |
| 334 | + | |
| 335 | + | |
| 336 | + | |
| 337 | + | |
| 338 | + | |
240 | 339 | | |
241 | 340 | | |
| 341 | + | |
| 342 | + | |
| 343 | + | |
| 344 | + | |
| 345 | + | |
| 346 | + | |
| 347 | + | |
| 348 | + | |
| 349 | + | |
| 350 | + | |
| 351 | + | |
| 352 | + | |
| 353 | + | |
| 354 | + | |
| 355 | + | |
| 356 | + | |
| 357 | + | |
| 358 | + | |
| 359 | + | |
| 360 | + | |
| 361 | + | |
| 362 | + | |
| 363 | + | |
| 364 | + | |
| 365 | + | |
| 366 | + | |
| 367 | + | |
| 368 | + | |
| 369 | + | |
| 370 | + | |
| 371 | + | |
| 372 | + | |
| 373 | + | |
| 374 | + | |
| 375 | + | |
| 376 | + | |
| 377 | + | |
| 378 | + | |
| 379 | + | |
| 380 | + | |
| 381 | + | |
| 382 | + | |
| 383 | + | |
| 384 | + | |
| 385 | + | |
242 | 386 | | |
243 | 387 | | |
244 | 388 | | |
| |||
546 | 690 | | |
547 | 691 | | |
548 | 692 | | |
| 693 | + | |
| 694 | + | |
| 695 | + | |
| 696 | + | |
| 697 | + | |
| 698 | + | |
| 699 | + | |
| 700 | + | |
| 701 | + | |
| 702 | + | |
| 703 | + | |
| 704 | + | |
| 705 | + | |
| 706 | + | |
| 707 | + | |
| 708 | + | |
| 709 | + | |
| 710 | + | |
| 711 | + | |
| 712 | + | |
| 713 | + | |
| 714 | + | |
| 715 | + | |
| 716 | + | |
| 717 | + | |
| 718 | + | |
| 719 | + | |
| 720 | + | |
| 721 | + | |
| 722 | + | |
| 723 | + | |
| 724 | + | |
| 725 | + | |
| 726 | + | |
| 727 | + | |
| 728 | + | |
| 729 | + | |
| 730 | + | |
549 | 731 | | |
550 | 732 | | |
551 | 733 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | | - | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
8 | 15 | | |
9 | 16 | | |
10 | 17 | | |
| |||
550 | 557 | | |
551 | 558 | | |
552 | 559 | | |
| 560 | + | |
| 561 | + | |
| 562 | + | |
| 563 | + | |
| 564 | + | |
| 565 | + | |
| 566 | + | |
| 567 | + | |
| 568 | + | |
| 569 | + | |
| 570 | + | |
| 571 | + | |
| 572 | + | |
| 573 | + | |
| 574 | + | |
| 575 | + | |
| 576 | + | |
| 577 | + | |
| 578 | + | |
| 579 | + | |
| 580 | + | |
| 581 | + | |
| 582 | + | |
| 583 | + | |
| 584 | + | |
| 585 | + | |
| 586 | + | |
| 587 | + | |
| 588 | + | |
| 589 | + | |
| 590 | + | |
| 591 | + | |
| 592 | + | |
| 593 | + | |
| 594 | + | |
| 595 | + | |
| 596 | + | |
| 597 | + | |
| 598 | + | |
| 599 | + | |
| 600 | + | |
| 601 | + | |
| 602 | + | |
| 603 | + | |
| 604 | + | |
| 605 | + | |
| 606 | + | |
| 607 | + | |
| 608 | + | |
| 609 | + | |
| 610 | + | |
| 611 | + | |
| 612 | + | |
| 613 | + | |
| 614 | + | |
| 615 | + | |
| 616 | + | |
553 | 617 | | |
554 | 618 | | |
555 | 619 | | |
| |||
668 | 732 | | |
669 | 733 | | |
670 | 734 | | |
| 735 | + | |
| 736 | + | |
| 737 | + | |
| 738 | + | |
| 739 | + | |
| 740 | + | |
| 741 | + | |
| 742 | + | |
| 743 | + | |
| 744 | + | |
| 745 | + | |
| 746 | + | |
| 747 | + | |
| 748 | + | |
| 749 | + | |
| 750 | + | |
| 751 | + | |
| 752 | + | |
| 753 | + | |
| 754 | + | |
| 755 | + | |
| 756 | + | |
| 757 | + | |
| 758 | + | |
| 759 | + | |
| 760 | + | |
| 761 | + | |
| 762 | + | |
| 763 | + | |
| 764 | + | |
| 765 | + | |
| 766 | + | |
| 767 | + | |
| 768 | + | |
| 769 | + | |
| 770 | + | |
| 771 | + | |
| 772 | + | |
| 773 | + | |
| 774 | + | |
| 775 | + | |
| 776 | + | |
| 777 | + | |
| 778 | + | |
| 779 | + | |
| 780 | + | |
| 781 | + | |
| 782 | + | |
| 783 | + | |
| 784 | + | |
| 785 | + | |
| 786 | + | |
| 787 | + | |
| 788 | + | |
| 789 | + | |
671 | 790 | | |
0 commit comments