Closed
Conversation
myitcv
force-pushed
the
rework_ast_highlight
branch
4 times, most recently
from
482e50b to
02ba44a
Compare
myitcv
changed the title
myitcv
force-pushed
the
rework_ast_highlight
branch
from
02ba44a to
8eb2567
Compare
myitcv
force-pushed
the
rework_ast_highlight
branch
8 times, most recently
from
5adaf9b to
07f1e91
Compare
myitcv
force-pushed
the
rework_ast_highlight
branch
7 times, most recently
from
e47cd17 to
6ae0b9b
Compare
myitcv
force-pushed
the
rework_ast_highlight
branch
2 times, most recently
from
10c0405 to
0b6c6c7
Compare
myitcv
force-pushed
the
rework_ast_highlight
branch
from
0b6c6c7 to
88d4283
Compare
myitcv
added a commit
that referenced
this pull request
May 30, 2019
Vim is not currently in a position to be able to accurately push viewport changes to govim. Hence, we might as well drop this code, not least because it clutters the log messages having the viewport changes being pushed the whole time. But also because we don't have anything in govim that relies on knowing when the viewport changes (that is #24). This should also make adding the Neovim support easier.
myitcv
added a commit
that referenced
this pull request
May 30, 2019
Vim is not currently in a position to be able to accurately push viewport changes to govim. Hence, we might as well drop this code, not least because it clutters the log messages having the viewport changes being pushed the whole time. But also because we don't have anything in govim that relies on knowing when the viewport changes (that is #24). This should also make adding the Neovim support easier.
myitcv
added a commit
that referenced
this pull request
May 30, 2019
Vim is not currently in a position to be able to accurately push viewport changes to govim. Hence, we might as well drop this code, not least because it clutters the log messages having the viewport changes being pushed the whole time. But also because we don't have anything in govim that relies on knowing when the viewport changes (that is #24). This should also make adding the Neovim support easier.
Member
Author
|
Closing for now. We can pick this up again later if necessary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Demo: https://youtu.be/OGtby_bjNUY
TODO:
matchaddposcalls to "stall"matchaddposanddeletematch:matchaddposcalls into line-based updatesmatchaddpossilent so that Vim does not redraw after each onegetwininfo()minus the"variables"key