You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit f05869b
Browse filesBrowse the repository at this point in the historyBrowse files
## Which issue does this PR close?
- Closesapache#24128.
## Rationale for this change
`PruningPredicateBuilder` is the extensible entry point for constructing
pruning predicates, but the construction logic still lived behind
`PruningPredicate::try_new`. Keeping the logic in the builder provides
one place to add future construction options and guides callers toward
the extensible API.
## What changes are included in this PR?
- Move pruning predicate construction into
`PruningPredicateBuilder::try_build`.
- Deprecate `PruningPredicate::try_new` and retain it as a compatibility
wrapper using the builder defaults.
- Migrate DataFusion call sites and examples to
`PruningPredicateBuilder`.
- Add a regression test confirming the deprecated constructor and
builder produce equivalent predicates.
## Are these changes tested?
Yes. The following checks pass:
- `cargo fmt --all -- --check`
- `cargo test -p datafusion-pruning`
- `cargo test -p datafusion-datasource-parquet`
- `cargo check -p datafusion-examples --examples`
- `cargo clippy -p datafusion-pruning -p datafusion-datasource-parquet
-p datafusion-examples --all-targets --all-features -- -D warnings`
- `cargo test --profile=ci --test sqllogictests`
- `cargo test -p datafusion`
- `cargo test -p datafusion-cli`
- `RUSTDOCFLAGS="-D warnings" cargo doc -p datafusion-pruning --no-deps`
The workspace-wide clippy command is currently blocked on `main` by an
existing `clippy::uninlined_format_args` diagnostic in
`datafusion/proto-common/src/generated/pbjson.rs`. The same failure
reproduces from a clean checkout of the base commit; all modified
packages pass strict clippy checks.
## Are there any user-facing changes?
Yes. `PruningPredicate::try_new` is deprecated as of 55.0.0. It remains
available as a compatibility wrapper with unchanged behavior. New
callers should construct predicates with `PruningPredicateBuilder`.
0 commit comments