Skip to content

Tell appveyor to enable symlinks#108

Merged
dnephin merged 1 commit intogotestyourself:masterfrom
vdemeester:windows-core-symlinks
Jul 9, 2018
Merged

Tell appveyor to enable symlinks#108
dnephin merged 1 commit intogotestyourself:masterfrom
vdemeester:windows-core-symlinks

Conversation

@vdemeester
Copy link
Member

@vdemeester vdemeester commented Jul 9, 2018

… should allow to run TestFromDirSymlink on windows

Closes #107

Signed-off-by: Vincent Demeester [email protected]

@vdemeester vdemeester requested a review from dnephin July 9, 2018 09:13
@vdemeester vdemeester force-pushed the windows-core-symlinks branch from 3ce17ec to c810d8e Compare July 9, 2018 09:14
@codecov
Copy link

codecov bot commented Jul 9, 2018

Codecov Report

Merging #108 into master will decrease coverage by 0.22%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #108      +/-   ##
==========================================
- Coverage   72.95%   72.72%   -0.23%     
==========================================
  Files          26       26              
  Lines        1856     1870      +14     
==========================================
+ Hits         1354     1360       +6     
- Misses        391      398       +7     
- Partials      111      112       +1
Impacted Files Coverage Δ
fs/report.go 78.57% <33.33%> (-1.6%) ⬇️
x/subtest/context.go 52.17% <0%> (-4.97%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb86f69...d44953d. Read the comment docs.

@vdemeester vdemeester force-pushed the windows-core-symlinks branch 5 times, most recently from 2120c1a to c5acf29 Compare July 9, 2018 09:29
… should allow to run `TestFromDirSymlink` on windows

Signed-off-by: Vincent Demeester <[email protected]>
@vdemeester vdemeester force-pushed the windows-core-symlinks branch from c5acf29 to d44953d Compare July 9, 2018 09:35
@@ -1,16 +1,18 @@
version: "{build}"
image: Visual Studio 2017
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image already contains Go (actually lots of versions 😛), see https://www.appveyor.com/docs/build-environment/#golang
We don't need to download/install it 😉

Copy link
Member

@dnephin dnephin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@dnephin dnephin merged commit 38c0997 into gotestyourself:master Jul 9, 2018
@vdemeester vdemeester deleted the windows-core-symlinks branch July 9, 2018 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants