packaging/windows: route install-time autostart through --configure-autostart

got3nks · got3nks · commit 6a033c4c1d9b · 2026-05-27T16:04:43.000+02:00
The installer's "Start aMule when I log in" Components-page section
now calls `amule.exe --configure-autostart on` via ExecWait instead
of writing the HKCU Run key directly. Puts the install-time path
and the Preferences → General checkbox through the same
AutostartManager API — OS-specific store details (HKCU Run on
Windows today; macOS LaunchAgent / Linux XDG .desktop on those
targets in the future) live in exactly one place.

Uninstaller's autostart cleanup left as-is: it has a safety check
that only deletes the Run value if it still points inside $INSTDIR,
so a user's hand-set value with a different path survives uninstall.
A blind `--configure-autostart off` would regress that check; not
worth losing for the symmetry.

UAC caveat preserved from the prior direct write: HKCU resolves to
the elevated context's hive — if a non-admin user enters a different
admin's password at UAC, the entry goes to that admin's HKCU
instead of the asker's. Fixing cleanly needs the UAC.dll plugin
which isn't worth pulling in for an opt-in single-machine convenience.
diff --git a/packaging/windows/installer.nsi b/packaging/windows/installer.nsi
@@ -240,10 +240,18 @@ Section "Desktop shortcut" SecDesktop
     "$INSTDIR\bin\amule.exe" "" "$INSTDIR\bin\amule.exe" 0
 SectionEnd
 
-; HKCU (per-user) so each user on a shared machine opts in independently.
+; Delegate to the same code path the Preferences → General checkbox
+; uses. AutostartManager owns the OS-specific store (HKCU Run on
+; Windows today; macOS LaunchAgent / Linux XDG .desktop on those
+; targets), so this section stays one line regardless of which
+; backend evolves how. Caveat preserved from the prior direct
+; WriteRegStr: HKCU resolves to the elevated context's hive — if a
+; non-admin user enters a different admin's password at UAC, the
+; entry goes to that admin's HKCU. Same behavior as before; fixing
+; it cleanly needs the UAC.dll plugin which isn't worth pulling in
+; for an opt-in single-machine convenience.
 Section /o "Start aMule when I log in" SecAutostart
-  WriteRegStr HKCU "Software\Microsoft\Windows\CurrentVersion\Run" \
-    "aMule" '"$INSTDIR\bin\amule.exe"'
+  ExecWait '"$INSTDIR\bin\amule.exe" --configure-autostart on'
 SectionEnd
 
 ; Component descriptions surfaced on the Components page.
