Skip to content

Fix parameter reference in template deduction#5

Merged
gorsing merged 1 commit intorefactoring_closure_dtemplatefrom
codex/fix-deducebaseclassparameters-argument-errors
Jul 22, 2025
Merged

Fix parameter reference in template deduction#5
gorsing merged 1 commit intorefactoring_closure_dtemplatefrom
codex/fix-deducebaseclassparameters-argument-errors

Conversation

@gorsing
Copy link
Copy Markdown
Owner

@gorsing gorsing commented Jul 22, 2025

Summary

  • fix deduceBaseClassParameters calls to pass TemplateParameters by reference
  • correct deduceType invocation inside deduceBaseClassParameters

Testing

  • make -j$(nproc) (fails: Couldn't find a D host compiler)

https://chatgpt.com/codex/tasks/task_e_688011b819688330a9feffea137ee56f

@gorsing gorsing merged commit 4731a24 into refactoring_closure_dtemplate Jul 22, 2025
@gorsing gorsing deleted the codex/fix-deducebaseclassparameters-argument-errors branch July 22, 2025 22:53
gorsing pushed a commit that referenced this pull request Oct 14, 2025
Limit the number of platforms that this is done on.  A inspection of
some libc implementations of fork has identified the main culprits,
don't need to apply this to any others.

MacOS testsuite also regressed as a result on calling this code, it's
not clear why, but the backtrace is:
```
* thread #1, queue = 'com.apple.main-thread', stop reason = EXC_BAD_INSTRUCTION (code=EXC_I386_INVOP, subcode=0x0)
  * frame #0: 0x00007ff81abe6ee3 libsystem_platform.dylib`_os_unfair_lock_recursive_abort + 23
    frame #1: 0x00007ff81abe12da libsystem_platform.dylib`_os_unfair_lock_lock_slow + 247
    frame #2: 0x00007ff81abccd44 libsystem_pthread.dylib`_pthread_atfork_prepare_handlers + 48
    frame #3: 0x00007ff825dc2705 libSystem.B.dylib`libSystem_atfork_prepare + 25
    frame #4: 0x00007ff81aac17e1 libsystem_c.dylib`fork + 24
    frame #5: 0x0000000101f730ee test_runner`core.internal.backtrace.dwarf.resolveAddressesWithAtos(Location[]) + 210
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant