Remove noisy printf in NextReader() and beginMessage()#878
Merged
AlexVulaj merged 1 commit intogorilla:mainfrom Dec 11, 2023
Merged
Remove noisy printf in NextReader() and beginMessage()#878AlexVulaj merged 1 commit intogorilla:mainfrom
AlexVulaj merged 1 commit intogorilla:mainfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
A recent check in causes
NextReader()andbeginMessage()to emit noisy, non-actionable messages that fill up application logs. This PR restores the previous approach of ignoring reader/writer close errors. This should address #852.Related Tickets & Documents
Added/updated tests?
Run verifications and test
make verifyis passingmake testis passing