test for github actions and remove old golang version#778
Closed
Nevereverest wants to merge 2 commits intogorilla:masterfrom
Nevereverest:master
Closed
test for github actions and remove old golang version#778Nevereverest wants to merge 2 commits intogorilla:masterfrom Nevereverest:master
Nevereverest wants to merge 2 commits intogorilla:masterfrom
Nevereverest:master
Conversation
Nevereverest
changed the title
tomaswarynyca
approved these changes
May 24, 2022
amustaque97
reviewed
Jun 12, 2022
amustaque97
left a comment
amustaque97
left a comment
There was a problem hiding this comment.
Hi @emp3826 are you still working on the PR?
Also, what are we trying to achieve here with PR?
Based on the reply we can continue our discussion because this PR requires some amount of work to be done in order to make it fit for merge else we can close the PR.
Thank you
ghost
mentioned this pull request
ghost
closed this
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
1.add test build to github actions
2.remove old golang version