Add check for Sec-WebSocket-Key header#752
Merged
2 commits merged intogorilla:masterfrom Feb 16, 2022
Merged
Conversation
hirasawayuki
force-pushed
the
check-sec-websocket-key
branch
from
c0eac79 to
4a6464d
Compare
Contributor
Author
|
@garyburd https://github.com/websockets/ws/blob/5edf1f4a1b1750109c1bb56eff7ad78902eee7dc/lib/websocket-server.js#L18 |
hirasawayuki
changed the title
hirasawayuki
force-pushed
the
check-sec-websocket-key
branch
from
4a6464d to
187c686
Compare
Contributor
Author
|
@garyburd |
ghost
merged commit 
|
There is a maximum limit of the incoming data per the base64 limit. You should add an error from the upgrader if the size is exceeded for two reasons:
|
|
The base64 alphabet has a limit per byte with regards to representation size. |
nono
referenced
this pull request
in cozy/cozy-stack
Nov 6, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/gorilla/websocket](https://togithub.com/gorilla/websocket) | require | patch | `v1.5.0` -> `v1.5.1` | --- ### Release Notes <details> <summary>gorilla/websocket (github.com/gorilla/websocket)</summary> ### [`v1.5.1`](https://togithub.com/gorilla/websocket/releases/tag/v1.5.1) [Compare Source](https://togithub.com/gorilla/websocket/compare/v1.5.0...v1.5.1) #### What's Changed - Add check for Sec-WebSocket-Key header by [@​hirasawayuki](https://togithub.com/hirasawayuki) in [https://github.com/gorilla/websocket/pull/752](https://togithub.com/gorilla/websocket/pull/752) - Changed the method name UnderlyingConn to NetConn by [@​JWSong](https://togithub.com/JWSong) in [https://github.com/gorilla/websocket/pull/773](https://togithub.com/gorilla/websocket/pull/773) - remove all versions < 1.16 and add 1.18 by [@​ChannyClaus](https://togithub.com/ChannyClaus) in [https://github.com/gorilla/websocket/pull/793](https://togithub.com/gorilla/websocket/pull/793) - Check for and report bad protocol in TLSClientConfig.NextProtos by [@​ChannyClaus](https://togithub.com/ChannyClaus) in [https://github.com/gorilla/websocket/pull/788](https://togithub.com/gorilla/websocket/pull/788) - check err before GotConn for trace by [@​junnplus](https://togithub.com/junnplus) in [https://github.com/gorilla/websocket/pull/798](https://togithub.com/gorilla/websocket/pull/798) - Update README.md by [@​coreydaley](https://togithub.com/coreydaley) in [https://github.com/gorilla/websocket/pull/839](https://togithub.com/gorilla/websocket/pull/839) - Correct way to save memory using write buffer pool and freeing net.http default buffers by [@​FMLS](https://togithub.com/FMLS) in [https://github.com/gorilla/websocket/pull/761](https://togithub.com/gorilla/websocket/pull/761) - Update go version & add verification/testing tools by [@​coreydaley](https://togithub.com/coreydaley) in [https://github.com/gorilla/websocket/pull/840](https://togithub.com/gorilla/websocket/pull/840) - update golang.org/x/net by [@​coreydaley](https://togithub.com/coreydaley) in [https://github.com/gorilla/websocket/pull/856](https://togithub.com/gorilla/websocket/pull/856) - update GitHub workflows by [@​coreydaley](https://togithub.com/coreydaley) in [https://github.com/gorilla/websocket/pull/857](https://togithub.com/gorilla/websocket/pull/857) #### New Contributors - [@​hirasawayuki](https://togithub.com/hirasawayuki) made their first contribution in [https://github.com/gorilla/websocket/pull/752](https://togithub.com/gorilla/websocket/pull/752) - [@​JWSong](https://togithub.com/JWSong) made their first contribution in [https://github.com/gorilla/websocket/pull/773](https://togithub.com/gorilla/websocket/pull/773) - [@​ChannyClaus](https://togithub.com/ChannyClaus) made their first contribution in [https://github.com/gorilla/websocket/pull/793](https://togithub.com/gorilla/websocket/pull/793) - [@​junnplus](https://togithub.com/junnplus) made their first contribution in [https://github.com/gorilla/websocket/pull/798](https://togithub.com/gorilla/websocket/pull/798) - [@​coreydaley](https://togithub.com/coreydaley) made their first contribution in [https://github.com/gorilla/websocket/pull/839](https://togithub.com/gorilla/websocket/pull/839) - [@​FMLS](https://togithub.com/FMLS) made their first contribution in [https://github.com/gorilla/websocket/pull/761](https://togithub.com/gorilla/websocket/pull/761) **Full Changelog**: gorilla/websocket@v1.5.0...v1.5.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 6am on Monday" in timezone Europe/Paris, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/cozy/cozy-stack). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMS41IiwidXBkYXRlZEluVmVyIjoiMzcuMzEuNSIsInRhcmdldEJyYW5jaCI6Im1hc3RlciJ9-->
ghost
mentioned this pull request
1 task
This was referenced Jan 2, 2024
algitbot
pushed a commit
to alpinelinux/build-server-status
that referenced
this pull request
May 5, 2024
This MR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/gorilla/websocket](https://github.com/gorilla/websocket) | require | patch | `v1.5.0` -> `v1.5.1` | --- ### Release Notes <details> <summary>gorilla/websocket (github.com/gorilla/websocket)</summary> ### [`v1.5.1`](https://github.com/gorilla/websocket/releases/tag/v1.5.1) [Compare Source](gorilla/websocket@v1.5.0...v1.5.1) #### What's Changed - Add check for Sec-WebSocket-Key header by [@​hirasawayuki](https://github.com/hirasawayuki) in gorilla/websocket#752 - Changed the method name UnderlyingConn to NetConn by [@​JWSong](https://github.com/JWSong) in gorilla/websocket#773 - remove all versions < 1.16 and add 1.18 by [@​ChannyClaus](https://github.com/ChannyClaus) in gorilla/websocket#793 - Check for and report bad protocol in TLSClientConfig.NextProtos by [@​ChannyClaus](https://github.com/ChannyClaus) in gorilla/websocket#788 - check err before GotConn for trace by [@​junnplus](https://github.com/junnplus) in gorilla/websocket#798 - Update README.md by [@​coreydaley](https://github.com/coreydaley) in gorilla/websocket#839 - Correct way to save memory using write buffer pool and freeing net.http default buffers by [@​FMLS](https://github.com/FMLS) in gorilla/websocket#761 - Update go version & add verification/testing tools by [@​coreydaley](https://github.com/coreydaley) in gorilla/websocket#840 - update golang.org/x/net by [@​coreydaley](https://github.com/coreydaley) in gorilla/websocket#856 - update GitHub workflows by [@​coreydaley](https://github.com/coreydaley) in gorilla/websocket#857 #### New Contributors - [@​hirasawayuki](https://github.com/hirasawayuki) made their first contribution in gorilla/websocket#752 - [@​JWSong](https://github.com/JWSong) made their first contribution in gorilla/websocket#773 - [@​ChannyClaus](https://github.com/ChannyClaus) made their first contribution in gorilla/websocket#793 - [@​junnplus](https://github.com/junnplus) made their first contribution in gorilla/websocket#798 - [@​coreydaley](https://github.com/coreydaley) made their first contribution in gorilla/websocket#839 - [@​FMLS](https://github.com/FMLS) made their first contribution in gorilla/websocket#761 **Full Changelog**: gorilla/websocket@v1.5.0...v1.5.1 </details> --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yODYuMSIsInVwZGF0ZWRJblZlciI6IjM3LjI4Ni4xIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIiwibGFiZWxzIjpbXX0=--> See merge request alpine/infra/build-server-status!9
](https://renovatebot.com){kind=link}
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue: #617
Added the following two fixes
RFC6455 states the following: