pool flate writers#194
Merged
1 commit merged intogorilla:masterfrom Dec 17, 2016
y3llowcake:flate_pool
Merged
Conversation
Contributor
Author
|
Hoping this is relatively uncontroversial, in theory it should only improve on existing performance characteristics. |
This was referenced Dec 15, 2016
Closed
ghost
reviewed
Dec 16, 2016
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
Add test for w.fw == nil in Write method.
| w.fw = nil | ||
| }() | ||
| err1 := w.fw.Flush() | ||
| if w.tw.p != [4]byte{0, 0, 0xff, 0xff} { |
There was a problem hiding this comment.
Remove the defer and add the following after Flush()
flatWritePool.Put(w.fw)
w.fw = nil
compression.go
Outdated
|
|
||
| func (w *flateWrapper) Close() error { | ||
| if w.fw == nil { | ||
| return errors.New("already closed") |
Contributor
Author
|
Done |
|
Does not compile. |
Contributor
Author
|
Sorry, I'm terrible with computers. This should be fixed now. |
ghost
merged commit 
ghost
locked and limited conversation to collaborators
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.