Use WriteJSON and ReadJSON on Conn struct.#1
Closed
tapocol wants to merge 3 commits intogorilla:masterfrom
Closed
Conversation
|
To prevent breaking existing code, please implement the old functions by calling the new connection methods. Note that the old functions are deprecated in the godoc comments for the functions. |
Contributor
Author
|
Hold on, didn't notice the DeepEqual in test. Just writing a brand new test for deprecated functions. |
|
The changes are merged to master. Thanks! |
ghost
closed this
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since it is already a requirement to give the *Conn struct and ReadMessage and WriteMessage were methods on *Conn, figured it made sense to adjust the JSON methods.