-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Closed
Labels
Description
Is there an existing issue for this?
- I have searched the existing issues
Current Behavior
Commit 666c197 is a huge commit with no useful log message, and I keep finding new issues with it.
One of the issues is that it included a bunch of error handling using log.Printf. gorilla/websocket is a generally useful library, and it should not be making any assumptions about my application's logging infrastructure; using log.Printf for logging is a clear violation of this basic principle.
Please revert commit 666c197.
Expected Behavior
A low-lever library should not be doing logging on behalf of the application.
Steps To Reproduce
No response
Anything else?
No response
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Type
Projects
Status
✅ Done