Skip to content
This repository was archived by the owner on Jul 21, 2021. It is now read-only.

More unused code cleaning #1009

Merged
gorhill merged 2 commits into from
Apr 7, 2019
Merged

More unused code cleaning #1009

gorhill merged 2 commits into from
Apr 7, 2019

Conversation

@rhendric
Copy link
Contributor

@rhendric rhendric commented Jan 27, 2019

  • remove many unused functions
  • remove XAL abstraction

@xofe
Copy link
Contributor

xofe commented Apr 7, 2019

Looks good to me, just might want to remove the <script src="js/xal.js"></script> line in ./src/background.html as you've deleted the file

@rhendric
Copy link
Contributor Author

rhendric commented Apr 7, 2019

🤦‍♂️ Yup, good point, did it!

@gorhill gorhill merged commit 3f2916e into gorhill:master Apr 7, 2019
@gorhill
Copy link
Owner

gorhill commented Apr 7, 2019

Thanks.

@rhendric rhendric deleted the cleaning branch April 7, 2019 18:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rhendric @xofe @gorhill