-
-
Notifications
You must be signed in to change notification settings - Fork 738
Comparing changes
Open a pull request
base repository: gorakhargosh/watchdog
base: v4.0.1
head repository: gorakhargosh/watchdog
compare: v4.0.2
- 15 commits
- 45 files changed
- 3 contributors
Commits on May 23, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 9f23b59 - Browse repository at this point
Copy the full SHA 9f23b59View commit details
Commits on Jul 21, 2024
-
docs: Simplify the quickstart example (#1047)
Personally, I found the quickstart example to be jumbled and a little confusing. It was hard for me to tell where I would put my own code to react to file system events (indeed the quickstart never showed how to do this). I also think the selection of the path using sys.argv and place everything under "if name == main" is unnecessary for the simple example.
Configuration menu - View commit details
-
Copy full SHA for 402ad01 - Browse repository at this point
Copy the full SHA 402ad01View commit details -
docs: Update PatternMatchingEventHandler documentation (#1048)
* Update PatternMatchingEventHandler documentation From the existing docs it's not clear what the difference is between PatternMatching and RegexMatching. Hopefully this makes it clearer. Also made a note that RegexMatching uses the re module, since there are various flavors of regex syntax and it's important to know which one is used. * Apply suggestions from code review --------- Co-authored-by: Mickaël Schoentgen <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 6294daf - Browse repository at this point
Copy the full SHA 6294dafView commit details
Commits on Jul 25, 2024
-
[fsevents] Add missing
event_filterkeyword-argument to `FSEventsOb……server.schedule()` (#1050)
Configuration menu - View commit details
-
Copy full SHA for ab5117a - Browse repository at this point
Copy the full SHA ab5117aView commit details
Commits on Jul 28, 2024
-
feat: centralize platform checks (#1051)
* feat: centralize platform checks * fixes * skip macOS pypy
Configuration menu - View commit details
-
Copy full SHA for 914923c - Browse repository at this point
Copy the full SHA 914923cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 206843c - Browse repository at this point
Copy the full SHA 206843cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4043ef0 - Browse repository at this point
Copy the full SHA 4043ef0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 654707e - Browse repository at this point
Copy the full SHA 654707eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7cd723a - Browse repository at this point
Copy the full SHA 7cd723aView commit details -
[core] Run ruff, apply several fixes (#1033)
- code simplifications here and there - introduce a proxy to guess the best `observer` class to import
Configuration menu - View commit details
-
Copy full SHA for 7d4a369 - Browse repository at this point
Copy the full SHA 7d4a369View commit details -
fix: possible race condition in
AutoRestartTrick(#1002)* fixes a possible race condition in AutoRestartTrick Just a long shot for a failure observed on #998. My hypothesis is that when we stop ProcessWatcher before we restart the process manually, we don't yield to it and immediately kill the process. Next, when the ProcessWatcher thread is woken up, we have to conditions ready - the popen_obj and stopped_event, see the corresponding code, ``` while True: if self.popen_obj.poll() is not None: break if self.stopped_event.wait(timeout=0.1): return ``` And desipte that `stopped_event` is set, we first check for `popen_obj` and trigger the process restart. We can also make the ProcessWatcher logic more robust, by checking if we are stopped before calling the termination callback, e.g., ``` try: if not self.stopped_event.is_set(): self.process_termination_callback() except Exception: logger.exception("Error calling process termination callback") ``` I am not 100% sure about that, as I don't really know what semantics is expected from ProcessWatcher by other users. But at least the AutoRestarter expects this semantics - i.e., a watcher shall not call any events after it was stopped. * tries an alternative solution i.e., don't send events if stopped
Configuration menu - View commit details
-
Copy full SHA for 7503d34 - Browse repository at this point
Copy the full SHA 7503d34View commit details -
Configuration menu - View commit details
-
Copy full SHA for cff604e - Browse repository at this point
Copy the full SHA cff604eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6a33516 - Browse repository at this point
Copy the full SHA 6a33516View commit details -
Configuration menu - View commit details
-
Copy full SHA for aac4328 - Browse repository at this point
Copy the full SHA aac4328View commit details
Commits on Aug 11, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 9c5a432 - Browse repository at this point
Copy the full SHA 9c5a432View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v4.0.1...v4.0.2