fix(ui): include zero values in donut legends#226
Merged
Conversation
Signed-off-by: Aysajan Eziz <[email protected]>
fahimfaisaal
approved these changes
Jul 15, 2026
fahimfaisaal
left a comment
fahimfaisaal
left a comment
Member
There was a problem hiding this comment.
Hi @AysajanE, thanks for the PR
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Keep donut arcs and percentage totals restricted to positive values while including genuine zero-valued series in the side legend as n/a and keeping missing series omitted, with focused regression tests.
Change
ui/src/composables/charts/shared/chartConfig.test.tsui/src/composables/charts/shared/chartConfig.tsChecks
PATH=/workspace/.northset/bootstrap-home/bin:/workspace/.northset/bootstrap-home/go/bin:$PATH pnpm --dir ui exec vitest run src/composables/charts/shared/chartConfig.test.ts— passed in a network-isolated container.PATH=/workspace/.northset/bootstrap-home/bin:/workspace/.northset/bootstrap-home/go/bin:$PATH pnpm --dir ui typecheck— passed in a network-isolated container.PATH=/workspace/.northset/bootstrap-home/bin:/workspace/.northset/bootstrap-home/go/bin:$PATH pnpm --dir ui format:check— passed in a network-isolated container.PATH=/workspace/.northset/bootstrap-home/bin:/workspace/.northset/bootstrap-home/go/bin:$PATH pnpm --dir ui test— passed in a network-isolated container.EMBED_UI=True PATH=/workspace/.northset/bootstrap-home/bin:/workspace/.northset/bootstrap-home/go/bin:$PATH pnpm --dir ui build— passed in a network-isolated container.PATH=/workspace/.northset/bootstrap-home/bin:/workspace/.northset/bootstrap-home/go/bin:$PATH GOMODCACHE=/workspace/.northset/bootstrap-home/project-go-mod go test -count=1 ./...— passed in a network-isolated container.PATH=/workspace/.northset/bootstrap-home/bin:/workspace/.northset/bootstrap-home/go/bin:$PATH GOMODCACHE=/workspace/.northset/bootstrap-home/project-go-mod golangci-lint run— passed in a network-isolated container.Fixes #204
AI assistance was used; I reviewed and own this change.
Verification
Northset proof-of-pass receipt M-031
This record covers Northset’s own contribution; it is not maintainer verification.
Maintainers can request a separate, private run for a PR already in their queue at [email protected].
For repositories already onboarded with Northset, adding
northset-verifyto a PR requests a run on that PR.