fix(ui): keep grouped 3D z-axis name with transparent text#199
Merged
Conversation
Empty z-axis names removed nameGap framing and made the metric scale look crushed on first view. Keep the axis name (and gap) for layout while rendering it transparent so the grouping column is not shown as a height title.
Only name + transparent color are needed; font size/weight and nameGap were copied from the visible axis helper without adding behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Follow-up to #192 / #188 — empty
zAxis3D.namefixed the misleading label but dropped title framing so the metric scale looked crushed on first view.Summary
Changes
axis3DNameInvisible()inui/src/composables/charts/shared/3d.ts(name+nameTextStyle.color: 'transparent'only).name: '').useGrouped3DZAxisLabel.test.tsto assert name + transparent color.docs/src/content/docs/charts/3d.mdx.Test Result
cd ui pnpm vitest run \ src/composables/charts/useGrouped3DZAxisLabel.test.ts \ src/composables/charts/useScatter3DChartOptions.test.ts \ src/composables/charts/shared/3d.test.tsAll tests passed.
Manual check (recommended):