fix: clear grouped 3D z-axis name under option merge#192
Conversation
|
Hi @ahfoysal, Thanks for the PR. The UI embed checks are failing. Please build the UI using Also sharing a short video or a screenshot of the UI changes would be great. |
|
I pushed the requested UI embed update and split the extra theme work out so this PR stays focused on issue 188. |
b961fa2 to
f95398e
Compare
|
Quick update: I split the earlier follow-up commit for issue 178 into a separate branch/PR so 192 remains focused on issue 188 only. Theme support is now tracked in PR #195. |
|
@ahfoysal before contributing to this repo, you have to have follow prerequisite. Like having go installed. Please read the Contributing.md file. to install go just use https://webinstall.dev/go/ |
|
Thanks, I reran this with Go installed.
|
|
@ahfoysal now run the Commit the file and push |
|
Done. I ran The command completed successfully locally. |
|
Nice, but now we have conflicts on the gen file. Please merge with latest main branch and regenerate the ui using |
Omitting the name left sticky labels when Chart3D merges options. Set name to empty string for bar/line/scatter grouped mode, keep value-mode metric labels, and document grouped z vs metric height.
fahimfaisaal
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
3 participants
Fixes #188.
Grouped 3D charts already show the z grouping in the legend, so this removes the misleading z-axis name from grouped bar, line, and scatter charts. Value-mode charts still label the z axis with the metric.
Checked: